Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

chore: update min Node.js version to 12.0.0, add support for Node.js v17 #1519

Merged
merged 20 commits into from
Nov 11, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,7 @@ jobs:
strategy:
fail-fast: false
matrix:
# We start at Node 10.18.0 because it is the first version filecoin's
# CBOR package will let us install. Once filecoin is moved out of the
# monorepo we want to use 10.7.0 (earliest version the Ethereum side
# supports) or 10.13.0 (first node 10 LTS version).
node: [10.18.0, 10.x, 11.x, 12.x, 13.x, 14.x, 15.x, 16.x]
node: [12.0.0, 12.x, 13.x, 14.x, 15.x, 16.x, 17.x]
os: [windows-2019, ubuntu-18.04, ubuntu-20.04, macos-11.0]

runs-on: ${{ matrix.os }}
Expand Down
6 changes: 1 addition & 5 deletions .github/workflows/push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,7 @@ jobs:
strategy:
fail-fast: false
matrix:
# We start at Node 10.18.0 because it is the first version filecoin's
# CBOR package will let us install. Once filecoin is moved out of the
# monorepo we want to use 10.7.0 (earliest version the Ethereum side
# supports) or 10.13.0 (first node 10 LTS version).
node: [10.18.0, 10.x, 11.x, 12.x, 13.x, 14.x, 15.x, 16.x]
node: [12.0.0, 12.x, 13.x, 14.x, 15.x, 16.x, 17.x]
os: [ubuntu-20.04]

runs-on: ${{ matrix.os }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
token: ${{ secrets.GITHUB_TOKEN }}
- uses: actions/setup-node@v1
with:
node-version: 14
node-version: 16

- name: Set git identity
run: |
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v10.13.0
v12.0.0
8 changes: 4 additions & 4 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@

## Getting set up

- Use Node.js v10.13.0.
- Why v10.13.0? Because this is the first version prettier supports.
- Use Node.js v12.0.0.
- Why v12.0.0? Because this is the first LTS release of Node.js v12 and is the earliest version Ganache supports.
- recommendation: use [nvm](https://github.com/nvm-sh/nvm) on Linux and macOS, and [nvm-windows](https://github.com/coreybutler/nvm-windows) on
Windows, to configure your node version.
- On Linux and macOS, if you have `nvm` installed, just run `nvm use` to switch to Node.js v10.13.0.
- On Linux and macOS, if you have `nvm` installed, just run `nvm use` to switch to Node.js v12.0.0.
- `git clone [email protected]:trufflesuite/ganache.git`
- `cd ganache`
- `npm install` (use npm v6)
Expand Down Expand Up @@ -153,7 +153,7 @@ index 2a2aa9e..57cbf21 100644

These are guidelines, not rules. :-)

- Use Node.js v10.13.0 for most local development.
- Use Node.js v12.0.0 for most local development.
- Use `bigint` literals, e.g., `123n`; if the number is externally configurable and/or could exceed
`Number.MAX_SAFE_INTEGER`.
- Write tests.
Expand Down
Loading