Add watch::Sender::send_replace
#3962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darksonn
approved these changes
Sep 25, 2021
suikammd
pushed a commit
to suikammd/tokio
that referenced
this pull request
Oct 7, 2021
jlebon
added a commit
to jlebon/ostree-rs-ext
that referenced
this pull request
Jun 24, 2022
We use `Sender::send_replace` which was added in 1.13.0: tokio-rs/tokio#3962 Closes: ostreedev#316
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
tokio::sync::watchchannel currently requires that each value sent into the channel is completely independent, but this means that the buffers of old values cannot be reused.Solution
Add
send_replacewhich allows the sender to retrieve the previous value that was in the channel. The naming is inspired bymem::replace.