This repository has been archived by the owner on Nov 7, 2024. It is now read-only.
lib: Bump tokio minimal version to 1.13.0 #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use `Sender::send_replace` which was added in 1.13.0: tokio-rs/tokio#3962 Closes: ostreedev#316
|
Wait, looks like there's more undeclared requirements. |
We use `atomic_write` which was added in 0.25: coreos/cap-std-ext#12
|
OK, got a local build now! I'm not quite sure why CI isn't hitting this. Probably related to the use of Swatinem/rust-cache? |
cgwalters
reviewed
Jun 24, 2022
|
Isn't the problem most likely that you have a local build for which you haven't run |
Oh yeah, that's clearly the immediate cause. I think it's just been a while since I've hacked on a Rust library (since for binaries we have Dependabot hooked up). |
|
OK fun, this one also hit #322 |
cgwalters
approved these changes
Jun 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use
Sender::send_replacewhich was added in 1.13.0:tokio-rs/tokio#3962
Closes: #316