-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use conformance runner binary for conformance tests #520
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, thanks Steve!
We are using protoc v3.12.0, and the corresponding proto files in packages/test-fixtures, but v22.3 of the conformance test runner. We have to keep them in sync. Let me take a closer look, maybe we can update in a follow-up.
Yeah, I considered that and was actually thinking a follow-up would be better if possible. I have a feeling the follow-up is going to be a decent amount of changes and didn't want to clutter this PR if we didn't have to. But, if it's better to stay in sync, I'm cool with doing it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do it one step at a time, LGTM.
This performs a few updates to the repository: