Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use conformance runner binary for conformance tests #520

Merged
merged 15 commits into from
Apr 24, 2023

Conversation

smaye81
Copy link
Collaborator

@smaye81 smaye81 commented Apr 22, 2023

This performs a few updates to the repository:

  • Switches from CircleCI to Github Actions for CI
  • Updates to Node 16 for the CI environment
  • Updates to use the published conformance runner binaries in Buf's protobuf-conformance repo.

@smaye81 smaye81 marked this pull request as ready for review April 22, 2023 01:02
@smaye81 smaye81 requested a review from timostamm April 22, 2023 01:02
Copy link
Owner

@timostamm timostamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thanks Steve!

We are using protoc v3.12.0, and the corresponding proto files in packages/test-fixtures, but v22.3 of the conformance test runner. We have to keep them in sync. Let me take a closer look, maybe we can update in a follow-up.

@smaye81
Copy link
Collaborator Author

smaye81 commented Apr 23, 2023

Yeah, I considered that and was actually thinking a follow-up would be better if possible. I have a feeling the follow-up is going to be a decent amount of changes and didn't want to clutter this PR if we didn't have to. But, if it's better to stay in sync, I'm cool with doing it here.

Copy link
Owner

@timostamm timostamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it one step at a time, LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants