Skip to content

Commit

Permalink
Merge pull request #520 from timostamm/sayers/use_conformance_release
Browse files Browse the repository at this point in the history
Use conformance runner binary for conformance tests
  • Loading branch information
smaye81 authored Apr 24, 2023
2 parents 0412fee + 3312232 commit 0abc247
Show file tree
Hide file tree
Showing 13 changed files with 31,870 additions and 46,561 deletions.
40 changes: 0 additions & 40 deletions .circleci/config.yml

This file was deleted.

62 changes: 62 additions & 0 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
name: ci
on:
pull_request:
branches: [master]
workflow_dispatch:
# Prevent writing to the repository using the CI token.
# Ref: https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#permissions
permissions: read-all
jobs:
ci:
runs-on: ubuntu-20.04
steps:
- name: checkout
uses: actions/checkout@v3

- name: Setup Go
if: success()
uses: actions/setup-go@v3
with:
go-version: 1.16.4

- name: Setup Node
if: success()
uses: actions/setup-node@v3
with:
node-version: 16

- name: Cache
uses: actions/cache@v3
with:
path: |
~/.tmp
.tmp
key: ${{ runner.os }}-protobuf-ts-ci-${{ hashFiles('Makefile') }}
restore-keys: |
${{ runner.os }}-protobuf-ts-ci-
- name: Install protoc
run: |
version=3.12.0
archive=protoc-${version}-linux-x86_64.zip
curl -O -L https://github.com/protocolbuffers/protobuf/releases/download/v${version}/${archive}
sudo unzip -d '/usr/local' ${archive} 'bin/*' 'include/*'
sudo chmod 755 /usr/local/bin/protoc
rm ${archive}
protoc --version
- name: Install conformance-test-runner
run: |
version=22.3
archive=conformance_test_runner-${version}-linux-x86_64.zip
curl -O -L https://github.com/bufbuild/protobuf-conformance/releases/download/v${version}/${archive}
unzip ${archive}
# sudo cp libprotobuf.so.23 /usr/lib/
sudo cp ./bin/conformance_test_runner /usr/bin/
sudo chmod 755 /usr/bin/conformance_test_runner
# rm libprotobuf.so.23
rm -rf ./bin
rm ${archive}
- name: Run make
run: make
4 changes: 1 addition & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,10 @@ Just [start a discussion](https://github.com/timostamm/protobuf-ts/discussions/n
### Building this project

Building and testing this project requires `node` (14.5.0), `npm`, `protoc` (3.12.3),
`make`, `bazel`, `git`, `go`.
`make`, `git`, and `go`.

- `go` is required for the Twirp transport client compatibility test suite
- `protoc` is required for test fixtures
- `git` and `bazel` are required to checkout and compile the protobuf conformance test
suite

The entire project can be built by running `make`, but if you do not have all required
tooling installed, you can still build all of the TypeScript packages.
Expand Down
Loading

0 comments on commit 0abc247

Please sign in to comment.