Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Landuse sort_key funk #555

Closed
nvkelso opened this issue Mar 3, 2016 · 8 comments
Closed

Landuse sort_key funk #555

nvkelso opened this issue Mar 3, 2016 · 8 comments
Assignees
@nvkelso
Milestone
v0.8.0

Comments

@nvkelso
Copy link
Member

nvkelso commented Mar 3, 2016

  • What did you see? Wood and other natural landuse are sorting above parks, a regression over v0.7 tiles.
  • What did you expect? It may actually be better this way, but it's different than before so noting it here. Might require design work?
  • What map location are you having problems with? East of San Francisco, example tile: http://vector.dev.mapzen.com/osm/all/11/329/791.topojson
  • Screenshot?

landuse-v0 8-beta-park-woods
@nvkelso nvkelso added the ready label Mar 3, 2016
@nvkelso
Copy link
Member Author

nvkelso commented Mar 3, 2016

cc @sensescape

@nvkelso
Copy link
Member Author

nvkelso commented Mar 3, 2016

Until we support alpha in Eraser Map dots, we should restore the older behavior.

Plus styles like Cinnabar, Refill, and Zinc don't have alpha so would need a different solution (like area grading).

@nvkelso
Copy link
Member Author

nvkelso commented Mar 3, 2016

These ones should move down more by forest:

grass           77
meadow          78
scrub           79
wetland         80
wood            81

They used to get no value in v0.7, which meant a client-side value of 1 (at the very bottom).

@nvkelso
Copy link
Member Author

nvkelso commented Mar 3, 2016

Other examples:

Vancouver: aquarium needs to be above wood

screen shot 2016-03-03 at 14 53 09

screen shot 2016-03-03 at 14 52 52

New York: wood needs to be above park

screen shot 2016-03-03 at 15 09 23

@nvkelso
Copy link
Member Author

nvkelso commented Mar 4, 2016

Note, glacier is in the same natural group, but is already at 11. beach is too, but v0.7 tiles has that at the top of the sort order at 4, and v8 already had it at 86 and that seems to be working. Glacier should probably move up to the same range as grass-wood.

@nvkelso nvkelso self-assigned this Mar 4, 2016
@nvkelso nvkelso added this to the v0.8.0 milestone Mar 4, 2016
@nvkelso
Copy link
Member Author

nvkelso commented Mar 4, 2016

But in Prospect Park it's actually better with the draft v0.8 sort_key values (wood above park):

#16/40.6619/-73.9679

screen shot 2016-03-03 at 17 54 42

@nvkelso
Copy link
Member Author

nvkelso commented Mar 4, 2016

The Vancouver example for Stanley Park (osm link) is a different bug related to ambiguous landuse kinds, where the feature is both park and wood, but for some reason it comes thru as wood. Even building a hierarchy of landuse based on area (#446) wouldn't solve that.

@nvkelso nvkelso mentioned this issue Mar 4, 2016
Merged
@nvkelso nvkelso added in review and removed ready labels Mar 4, 2016
@nvkelso
Copy link
Member Author

nvkelso commented Mar 4, 2016

Let's limit any more changes to landuse in v0.8 to just these. (It's just pushing around chairs on the Titanic until #446 is added.)

@nvkelso nvkelso closed this as completed in b17377a Mar 4, 2016
nvkelso added a commit that referenced this issue Mar 4, 2016
@nvkelso
Merge pull request #559 from mapzen/nvkelso/landuse-natural-fixes
b87afc3 
fixes #555 landuse funk
@nvkelso nvkelso removed the in review label Mar 4, 2016
rmarianski added a commit that referenced this issue Mar 4, 2016
@rmarianski
Merge branch 'master' into dev
7d130a1 
* master:
  Add test and cases for brunnel defaults.
  Sort keys changed, update test.
  move <=15 zoom filters topside
  Revert min_zoom to previous behaviour.
  Add tests.
  Add min_zoom property to buildings.
  Disable area/volume filter at z16.
  Buildings should satisfy this filter if they meet the minimum volume or minimum area limits.
  Show all buildings at z16
  connects to #556 for road brunnel, level sorting zoom>=15
  fixes #555 landuse funk
  Update ISSUE_TEMPLATE.md
  add back regressions for man_made, national_park, natural
  Update docs for water sort key.
  Added test for water boundary sort key. The 'boundary: yes' key is only added by the exterior boundaries post-processor, so the sort key post-processor needs to come after it.
  move parking topside, and remove dup park

Conflicts:
	data/functions.sql
rmarianski added a commit that referenced this issue Mar 4, 2016
@rmarianski
Merge branch 'master' into prod
03f33a3 
* master: (98 commits)
  Relax road rules for bridges/tunnels at low zooms
  Add test and cases for brunnel defaults.
  Sort keys changed, update test.
  move <=15 zoom filters topside
  Revert min_zoom to previous behaviour.
  Add tests.
  Add min_zoom property to buildings.
  Disable area/volume filter at z16.
  Buildings should satisfy this filter if they meet the minimum volume or minimum area limits.
  Show all buildings at z16
  connects to #556 for road brunnel, level sorting zoom>=15
  fixes #555 landuse funk
  Update ISSUE_TEMPLATE.md
  add back regressions for man_made, national_park, natural
  Update docs for water sort key.
  Added test for water boundary sort key. The 'boundary: yes' key is only added by the exterior boundaries post-processor, so the sort key post-processor needs to come after it.
  move parking topside, and remove dup park
  Configure csvmatcher for remaining layers
  Replace call to roads sort key with a spreadsheet.
  Made tests for sort keys in the roads layer.
  ...

Conflicts:
	data/apply-planet_osm_point.sql
	data/apply-planet_osm_polygon.sql
	data/functions.sql
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nvkelso nvkelso

Labels
None yet
Projects
None yet
Milestone
v0.8.0
Development

No branches or pull requests
1 participant
@nvkelso