Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambiguous landuse values (from different OSM keys) #132

Closed
rmarianski opened this issue Aug 13, 2015 · 5 comments
Closed

Ambiguous landuse values (from different OSM keys) #132

rmarianski opened this issue Aug 13, 2015 · 5 comments
Assignees
Milestone

Comments

@rmarianski
Copy link
Member

There are situations where the kind value doesn't have the most appropriate tag's value in it. We should also return back the value that is in the landuse tag on the feature to help with these situations.

@rmarianski
Copy link
Member Author

@nvkelso we discussed a separate approach offline too where we could expand the possible values in the kind to capture this. For example: kind=station (power)

When it's ambiguous, do we want to include the source tag, in this case landuse? Or, add more kind values?

@nvkelso
Copy link
Member

nvkelso commented Sep 11, 2015

I'm starting to lean towards kind=station_power where we postfix the original key namespace. Do we do this all the time (no, this would break the simplicity of coalescing into kind), only when there are known collisions (yes). But do we force the postfix on all confusing values, or not on the dominant usage and only on the minor usages? Adding it only for the minor usages seems less like is more of a feature (and wouldn't regress existing stylesheets and cause issues for customers).

@zerebubuth What are your thoughts?

@nvkelso nvkelso changed the title Include landuse tag in landuse layers Ambiguous landuse values (from different OSM keys) Sep 11, 2015
@zerebubuth
Copy link
Member

If we prefix the kind with the original key and then separate the key and value with an = then we haven't lost any information 😉

I guess the best solution to any of this is to come up with a single, unique string to represent every feature that we want to pull in. That's going to be a bunch of work, which is why I think it might be easier to just stick with the OSM key=value pairs.

@nvkelso nvkelso modified the milestones: Compilation 2.0, Compilation 2.1 Sep 25, 2015
@nvkelso
Copy link
Member

nvkelso commented Oct 15, 2015

Another example where playground should loose out to pier:
http://vector.mapzen.com/osm/all/19/154336/197070.topojson?api_key=vector-tiles-HqUVidw

@nvkelso nvkelso modified the milestones: v1.0.0, Compilation 2.1 Apr 4, 2016
@nvkelso
Copy link
Member

nvkelso commented Aug 29, 2016

Most of this was done via other commits.

The one actionable item from this issue if for power stations, which was elsewhere changed to export {kind: substation}. Closing this in favor of new issues with specific problems.

I see pier but no playground in tile commented Oct of last year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants