Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add another except for any OAuth2Errors #540

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

MelissaAutumn
Copy link
Member

Fixes #538

Copy link
Collaborator

@devmount devmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the joy of error handling 😅 Maybe we should also add a general except here to catch errors that are not of a type that's already handled?

@MelissaAutumn MelissaAutumn merged commit 77592ed into main Jul 11, 2024
4 checks passed
@MelissaAutumn MelissaAutumn deleted the bugs/538-fix-zoom-meeting-oauth-crash branch July 11, 2024 19:29
devmount added a commit that referenced this pull request Jul 16, 2024
* Bake in the github short sha as the container's release version. (#531)

* Bake in the github short sha as the container's release version.

* changed github_sha syntax for consistency within the file

---------

Co-authored-by: Jo <[email protected]>

* Bugs/517 ftue qa (#532)

* Don't overwrite app theme, just remove the dark class from html.

* * Require one weekday to be selected
* Adjust styling of notice bar
* Dynamically show warnings on notice bar
* Add missing chip

* Remove hardcoded cert (#533)

* converted ssl cert to a variable

* update ssl cert in validate workflow

* corrected ssl cert variable reference (#534)

* added env variable declaration (#535)

* Replace yarn with npm (#537)

* Replace yarn with npm

* Fix validation workflow

* Oops, also swap yarn here.

* Add package lock

* Waiting List Admin Panel (Readonly) (#536)

* Add initial waiting list admin panel.

Read-only for now, with some filters.

* Add tests

* 🌐 Update German translation

* Adjust script tag and remove console log

---------

Co-authored-by: Andreas Müller <[email protected]>

* added recursive flag to frontend zip command (#539)

* Add another except for any OAuth2Errors (#540)

* Schedule booking confirmation (#519)

* ➕ Add schedule booking confirmation

* ➕ Enhance schedule API to handle bookings without confirmation

* 🔨 Show proper success message depending on confirmation status

* 🔨 Make field nullable and fix fn return

* 🌐 Update frontend/src/locales/en.json

Co-authored-by: Mel <[email protected]>

* 🌐 Update German translation

* 🔨 Assume appointment mustn't be null

---------

Co-authored-by: Mel <[email protected]>

* Add types for utils (#520)

* Configuration to fix HMR (#527)

* ➕ Add configuration to fix HMR

* 🔨 Make polling optional by env var

* 🔨 Fix merge config

* 🔨 Only use necessary options

* Update English heading cases (#548)

* Use server_default for migrations, and fix a logic error from my suggestion (#549)

---------

Co-authored-by: Mel <[email protected]>
Co-authored-by: Jo <[email protected]>
devmount added a commit that referenced this pull request Jul 17, 2024
* ➕ Add types for components elements subdirectories

* 🔨 Fix merge conflicts

* Catch up from main (#551)

* Bake in the github short sha as the container's release version. (#531)

* Bake in the github short sha as the container's release version.

* changed github_sha syntax for consistency within the file

---------

Co-authored-by: Jo <[email protected]>

* Bugs/517 ftue qa (#532)

* Don't overwrite app theme, just remove the dark class from html.

* * Require one weekday to be selected
* Adjust styling of notice bar
* Dynamically show warnings on notice bar
* Add missing chip

* Remove hardcoded cert (#533)

* converted ssl cert to a variable

* update ssl cert in validate workflow

* corrected ssl cert variable reference (#534)

* added env variable declaration (#535)

* Replace yarn with npm (#537)

* Replace yarn with npm

* Fix validation workflow

* Oops, also swap yarn here.

* Add package lock

* Waiting List Admin Panel (Readonly) (#536)

* Add initial waiting list admin panel.

Read-only for now, with some filters.

* Add tests

* 🌐 Update German translation

* Adjust script tag and remove console log

---------

Co-authored-by: Andreas Müller <[email protected]>

* added recursive flag to frontend zip command (#539)

* Add another except for any OAuth2Errors (#540)

* Schedule booking confirmation (#519)

* ➕ Add schedule booking confirmation

* ➕ Enhance schedule API to handle bookings without confirmation

* 🔨 Show proper success message depending on confirmation status

* 🔨 Make field nullable and fix fn return

* 🌐 Update frontend/src/locales/en.json

Co-authored-by: Mel <[email protected]>

* 🌐 Update German translation

* 🔨 Assume appointment mustn't be null

---------

Co-authored-by: Mel <[email protected]>

* Add types for utils (#520)

* Configuration to fix HMR (#527)

* ➕ Add configuration to fix HMR

* 🔨 Make polling optional by env var

* 🔨 Fix merge config

* 🔨 Only use necessary options

* Update English heading cases (#548)

* Use server_default for migrations, and fix a logic error from my suggestion (#549)

---------

Co-authored-by: Mel <[email protected]>
Co-authored-by: Jo <[email protected]>

* ➕ Add types to calendar elements

* 🔨 Fix type errors

* 🔨 Rename type

---------

Co-authored-by: Mel <[email protected]>
Co-authored-by: Jo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App crash when trying to create zoom meeting
2 participants