Schedule booking confirmation #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmount
commented
Jul 4, 2024
devmount
commented
Jul 4, 2024
frontend/src/locales/en.json
Outdated
| @@ -317,6 +358,7 @@ | |||
| "continueToFxa": "Enter your email above to continue to Mozilla Accounts" | |||
| }, | |||
| "nameIsInvitingYou": "{name} is inviting you", | |||
| "ownerNeedsToConfirmBooking": "If this option is active, appointments are only booked until the calendar owner confirmed it.", | |||
There was a problem hiding this comment.
Please correct my bad English if necessary. In this context it might be even better to say "until you confirmed them", because it's displayed only for the one editing their schedule.
MelissaAutumn
requested changes
Jul 11, 2024
...ppointment/migrations/versions/2024_07_04_1501-fb1feb76c467_schedule_booking_confirmation.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Mel <[email protected]>
devmount
added a commit
that referenced
this pull request
Jul 16, 2024
* Bake in the github short sha as the container's release version. (#531) * Bake in the github short sha as the container's release version. * changed github_sha syntax for consistency within the file --------- Co-authored-by: Jo <[email protected]> * Bugs/517 ftue qa (#532) * Don't overwrite app theme, just remove the dark class from html. * * Require one weekday to be selected * Adjust styling of notice bar * Dynamically show warnings on notice bar * Add missing chip * Remove hardcoded cert (#533) * converted ssl cert to a variable * update ssl cert in validate workflow * corrected ssl cert variable reference (#534) * added env variable declaration (#535) * Replace yarn with npm (#537) * Replace yarn with npm * Fix validation workflow * Oops, also swap yarn here. * Add package lock * Waiting List Admin Panel (Readonly) (#536) * Add initial waiting list admin panel. Read-only for now, with some filters. * Add tests * 🌐 Update German translation * Adjust script tag and remove console log --------- Co-authored-by: Andreas Müller <[email protected]> * added recursive flag to frontend zip command (#539) * Add another except for any OAuth2Errors (#540) * Schedule booking confirmation (#519) * ➕ Add schedule booking confirmation * ➕ Enhance schedule API to handle bookings without confirmation * 🔨 Show proper success message depending on confirmation status * 🔨 Make field nullable and fix fn return * 🌐 Update frontend/src/locales/en.json Co-authored-by: Mel <[email protected]> * 🌐 Update German translation * 🔨 Assume appointment mustn't be null --------- Co-authored-by: Mel <[email protected]> * Add types for utils (#520) * Configuration to fix HMR (#527) * ➕ Add configuration to fix HMR * 🔨 Make polling optional by env var * 🔨 Fix merge config * 🔨 Only use necessary options * Update English heading cases (#548) * Use server_default for migrations, and fix a logic error from my suggestion (#549) --------- Co-authored-by: Mel <[email protected]> Co-authored-by: Jo <[email protected]>
devmount
added a commit
that referenced
this pull request
Jul 17, 2024
* ➕ Add types for components elements subdirectories * 🔨 Fix merge conflicts * Catch up from main (#551) * Bake in the github short sha as the container's release version. (#531) * Bake in the github short sha as the container's release version. * changed github_sha syntax for consistency within the file --------- Co-authored-by: Jo <[email protected]> * Bugs/517 ftue qa (#532) * Don't overwrite app theme, just remove the dark class from html. * * Require one weekday to be selected * Adjust styling of notice bar * Dynamically show warnings on notice bar * Add missing chip * Remove hardcoded cert (#533) * converted ssl cert to a variable * update ssl cert in validate workflow * corrected ssl cert variable reference (#534) * added env variable declaration (#535) * Replace yarn with npm (#537) * Replace yarn with npm * Fix validation workflow * Oops, also swap yarn here. * Add package lock * Waiting List Admin Panel (Readonly) (#536) * Add initial waiting list admin panel. Read-only for now, with some filters. * Add tests * 🌐 Update German translation * Adjust script tag and remove console log --------- Co-authored-by: Andreas Müller <[email protected]> * added recursive flag to frontend zip command (#539) * Add another except for any OAuth2Errors (#540) * Schedule booking confirmation (#519) * ➕ Add schedule booking confirmation * ➕ Enhance schedule API to handle bookings without confirmation * 🔨 Show proper success message depending on confirmation status * 🔨 Make field nullable and fix fn return * 🌐 Update frontend/src/locales/en.json Co-authored-by: Mel <[email protected]> * 🌐 Update German translation * 🔨 Assume appointment mustn't be null --------- Co-authored-by: Mel <[email protected]> * Add types for utils (#520) * Configuration to fix HMR (#527) * ➕ Add configuration to fix HMR * 🔨 Make polling optional by env var * 🔨 Fix merge config * 🔨 Only use necessary options * Update English heading cases (#548) * Use server_default for migrations, and fix a logic error from my suggestion (#549) --------- Co-authored-by: Mel <[email protected]> Co-authored-by: Jo <[email protected]> * ➕ Add types to calendar elements * 🔨 Fix type errors * 🔨 Rename type --------- Co-authored-by: Mel <[email protected]> Co-authored-by: Jo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This change adds a switch to toggle off booking confirmation.
Benefits
If users don't need the additional layer of safety from flooding their calendar with events, they can make the booking process for potential attendees much faster.
Applicable Issues
Closes #460