Change SemVer range for @tenderly/hardhat-tenderly dependency
#134
+178
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't use `@tenderly/hardhat-tenderly` in versions `1.4.x` and higher on Node.js `v14`, as those `1.4.x` versions introduce dependency to `tslog` package, which is incompatible with `v14` of Node.js (works on `v16` or higher). We use Node `v14` in some of the projects having the `@threshold-network/solidity-contracts` as their dependency. We had also a problem with installation of `@tenderly/hardhat-tenderly` in versions `1.2.x`, so we're limiting the allowed versions to `<1.2.0`.
deployment
michalinacienciala
requested review from
nkuba and
a team
and removed request for
nkuba
This was referenced Dec 22, 2022
r-czajkowski
approved these changes
Dec 23, 2022
r-czajkowski
added a commit
to keep-network/keep-core
that referenced
this pull request
Dec 23, 2022
We can't use `@tenderly/hardhat-tenderly` in versions `1.4.x` and higher on Node.js `v14`, as those `1.4.x` versions introduce dependency to `tslog` package, which is incompatible with `v14` of Node.js (works on `v16` or higher). We use Node `v14` in some of the projects having the `@keep-network/random-beacon` and `@keep-network/ecdsa` as their dependency. There are also some problems with deployment scripts (possibly fixable) on `@tenderly/hardhat-tenderly` in versions `1.2.x`, so we're limiting the allowed versions to `<1.2.0`. Refs: threshold-network/solidity-contracts#134 keep-network/tbtc-v2#440 keep-network/coverage-pools#222
r-czajkowski
added a commit
to keep-network/coverage-pools
that referenced
this pull request
Dec 23, 2022
…sion We can't use `@tenderly/hardhat-tenderly` in versions `1.4.x` and higher on Node.js `v14`, as those `1.4.x` versions introduce dependency to `tslog` package, which is incompatible with `v14` of Node.js (works on `v16` or higher). We use Node `v14` in some of the projects having the `@keep-network/coverage-pools` as their dependency. There are also some problems with deployment scripts (possibly fixable) on `@tenderly/hardhat-tenderly` in versions `1.2.x`, so we're limiting the allowed versions to `<1.2.0`. Refs: threshold-network/solidity-contracts#134 keep-network/tbtc-v2#440 keep-network/keep-core#3454
r-czajkowski
added a commit
that referenced
this pull request
Jan 2, 2023
…y-version-2
Change SemVer range for `@tenderly/hardhat-tenderly` dependency
Some time ago we had the SemVer range for the `@tenderly/hardhat-tenderly`
dependency defined as `^1.0.12` and resolved in the `yarn.lock` to `1.0.13`
version.
But we discoverd that this is problematic when `solidity-contracts` project is
used as a dependency in projects where `yarn upgrade` is run on Node.js v14,
because then the `@tenderly/hardhat-tenderly` dependency gets resolved to
`1.4.x` versions which are incompatible with Node.js v14 (to be precise, their
`tslog` subdependency isn't working on `v14`).
So we decided to limit the SemVer range for the `@tenderly/hardhat-tenderly`
dependency. We've limitted it from top to `<1.2.0` versions, which resolved the
rependency in `yarn.lock` to `1.1.6` (we didn't allow higher versions as they
proved to be problematic due to some other reasons).
But now we discovered that `1.1.6` and other `1.1.x` versions are not working
with our config either - when `npm publish --access=public --network=hardhat
--tag=development` command is run, there are errors similar to this:
```
Error:
node_modules/@nomiclabs/hardhat-ethers/internal/type-extensions.d.ts(8,10):
error TS2300: Duplicate identifier 'Libraries'.
```
or this:
```
hardhat.config.ts:87:3 - error TS2741: Property 'forkNetwork' is missing in
type '{ username: string; project: string; }' but required in type
'TenderlyConfig'.
```
So now we're specifying the range as `>=1.0.12 <1.1.0` and resolve it to the
`1.0.15` version, which does not cause any problems with publishing.
Ref:
#134
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't use
@tenderly/hardhat-tenderlyin versions1.4.xand higher on Node.jsv14, as those1.4.xversions introduce dependency totslogpackage, which is incompatible withv14of Node.js (works onv16or higher). We use Nodev14in some of the projects having the@threshold-network/solidity-contractsas their dependency.We had also a problem with installation of
@tenderly/hardhat-tenderlyin versions1.2.x, so we're limiting the allowed versions to<1.2.0.Refs:
keep-network/tbtc-v2#440
keep-network/keep-core#3454
keep-network/coverage-pools#222