Change SemVer range for @tenderly/hardhat-tenderly dependency
#440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't use `@tenderly/hardhat-tenderly` in versions `1.4.x` and higher on Node.js `v14`, as those `1.4.x` versions introduce dependency to `tslog` package, which is incompatible with `v14` of Node.js (works on `v16` or higher). There are also some problems with deployment scripts (possibly fixable) on `@tenderly/hardhat-tenderly` in versions `1.2.x`, so we're limiting the allowed versions to `<1.2.0`.
nkuba
approved these changes
Dec 22, 2022
This was referenced Dec 22, 2022
r-czajkowski
added a commit
to keep-network/keep-core
that referenced
this pull request
Dec 23, 2022
We can't use `@tenderly/hardhat-tenderly` in versions `1.4.x` and higher on Node.js `v14`, as those `1.4.x` versions introduce dependency to `tslog` package, which is incompatible with `v14` of Node.js (works on `v16` or higher). We use Node `v14` in some of the projects having the `@keep-network/random-beacon` and `@keep-network/ecdsa` as their dependency. There are also some problems with deployment scripts (possibly fixable) on `@tenderly/hardhat-tenderly` in versions `1.2.x`, so we're limiting the allowed versions to `<1.2.0`. Refs: threshold-network/solidity-contracts#134 keep-network/tbtc-v2#440 keep-network/coverage-pools#222
r-czajkowski
added a commit
to keep-network/coverage-pools
that referenced
this pull request
Dec 23, 2022
…sion We can't use `@tenderly/hardhat-tenderly` in versions `1.4.x` and higher on Node.js `v14`, as those `1.4.x` versions introduce dependency to `tslog` package, which is incompatible with `v14` of Node.js (works on `v16` or higher). We use Node `v14` in some of the projects having the `@keep-network/coverage-pools` as their dependency. There are also some problems with deployment scripts (possibly fixable) on `@tenderly/hardhat-tenderly` in versions `1.2.x`, so we're limiting the allowed versions to `<1.2.0`. Refs: threshold-network/solidity-contracts#134 keep-network/tbtc-v2#440 keep-network/keep-core#3454
r-czajkowski
added a commit
to threshold-network/solidity-contracts
that referenced
this pull request
Dec 23, 2022
…y-version Change SemVer range for `@tenderly/hardhat-tenderly` dependency We can't use `@tenderly/hardhat-tenderly` in versions `1.4.x` and higher on Node.js `v14`, as those `1.4.x` versions introduce dependency to `tslog` package, which is incompatible with `v14` of Node.js (works on `v16` or higher). We use Node `v14` in some of the projects having the `@threshold-network/solidity-contracts` as their dependency. We had also a problem with installation of `@tenderly/hardhat-tenderly` in versions `1.2.x`, so we're limiting the allowed versions to `<1.2.0`. Refs: keep-network/tbtc-v2#440 keep-network/keep-core#3454 keep-network/coverage-pools#222
r-czajkowski
added a commit
that referenced
this pull request
Jan 5, 2023
We changed the version range for `@tenderly/hardhat-tenderly` in #440 and CI build fails on tenderly verification. Since this is a `dapp-development` branch, we do not actually need the tenderly verification at least for now so here we remove the `tenderly` tag for `goerli` network to skip the tenderly veirification.
r-czajkowski
added a commit
that referenced
this pull request
Jan 19, 2023
We changed the version range for `@tenderly/hardhat-tenderly` in #440 and CI build fails on tenderly verification. Since this is a `dapp-development` branch, we do not actually need the tenderly verification at least for now so here we remove the `tenderly` tag for `goerli` network to skip the tenderly veirification.
pdyraga
added
⛓️ solidity
deployment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't use
@tenderly/hardhat-tenderlyin versions1.4.xand higher on Node.jsv14, as those1.4.xversions introduce dependency totslogpackage, which is incompatible withv14of Node.js (works onv16or higher). There are also some problems with deployment scripts (possibly fixable) on@tenderly/hardhat-tenderlyin versions1.2.x, so we're limiting the allowed versions to<1.2.0.Using
"@tenderly/hardhat-tenderly": "^1.0.12"intbtc-v2was causing problems with building/testing of the@threshold-network/solidity-contracts, where we upgrade thetbtc-v2dependency.