feat: add dedicated test cases to ensure copy and move methods to always overwrite target #1808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ays overwrite target
5 tasks
… using dedicated configs
tinect
force-pushed
the
feat/testMoveAndCopyTasks
branch
from
39146ca to
f650a7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #1764
from docs: https://flysystem.thephpleague.com/docs/usage/filesystem-api/
We might want to add more tests to ensure the config (e.g. visibility) is updated? I don't like to add these into this tests, but into seperate once like
copying_a_file_with_same_destination_with_updated_visibilityso, any adapter can overwrite/skip this test, while it does not support visibility.Apart from this, this PR introduces tests for more reliable adapters.
What do you think?