Adding and ensuring more dedicated tests

[tinect]

Feature Request

Using different adapters, I always see different behaviours. This could be avoided, if there were more dedicated tests in AdapterTestUtilities.

• fileExists should not be true, if it is a directory (chore: add tests to test fileExists onto directory and vice-versa #1789)
• directoryExists should not be true, if it is a file (chore: add tests to test fileExists onto directory and vice-versa #1789)

Currently, It is not clear what should happen, when:

• move/copy any file onto any other existing file? feat: add dedicated test cases to ensure copy and move methods to always overwrite target #1808
  • a few throw exceptions, some just overwrite
• move/copy any file to the same destination? feat: add dedicated test cases to ensure copy and move methods to always overwrite target #1808
• a few throw exceptions, others remove the file, others just updating the visibility
• deleteDirectory which does not exist
  • a few throw exceptions, others ignore it

[tinect]

@frankdejonge is this something we can talk about for v4?

[SamMousa]

From docs https://flysystem.thephpleague.com/docs/usage/filesystem-api/

Moving and copying are both deterministic operations. This means they will always overwrite the target location, and parent directories are always created (if and when needed)

The other 2 points remain though.

[tinect]

Oh, I forgot the page. but yes, then it is not valid for several adapters.

[SamMousa]

Those could be files as bugs and be fixed without major release i guess?