Feature/paragraph updates #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sensational-seahorse-8635f8 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sqrcz
commented
Dec 13, 2023
| @@ -19,7 +19,7 @@ npm i flowbite flowbite-vue | |||
| ```javascript | |||
| module.exports = { | |||
| content: [ | |||
| 'node_modules/flowbite-vue/**/*.{js,jsx,ts,tsx}', | |||
| 'node_modules/flowbite-vue/**/*.{js,jsx,ts,tsx,vue}', | |||
There was a problem hiding this comment.
this change was required for custom classes like last:mb-0 to be visible in projects using flowbite-vue (without it custom classes like that was not discovered by Tailwindcss.
Sqrcz
commented
Dec 13, 2023
| @@ -1,4 +1,4 @@ | |||
| import { twMerge } from 'tailwind-merge' | |||
|
|
|||
| export const useMergeClasses = (componentClasses: string): string => | |||
| export const useMergeClasses = (componentClasses: string | string[]): string => | |||
There was a problem hiding this comment.
twMerge accepts both types... so we shouldn't limit those here.
cogor
approved these changes
Dec 15, 2023
|
LGTM |
cogor
added
📚 documentation
|
OK, I've removed all props as those were just class wrappers. |
cogor
reviewed
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update for point 1. on List of random issues
classprop addeduseMergeClasses()used to manage user classesdefaultClassesproperty with default classes:mb-3 last:mb-0colorprop removed (it was just an unnecessary wrapper/middleware for tailwind classes)colordefault value moved todefaultClassesAs now with
useMergeClasses()user can easily set them... I would like to remove as well other props that exist only for setting tailwind classes.If you agree I'll remove them in the next commit.