List of random issues

[Sqrcz]

Hey 👋

While refactoring this library to introduce component prefix and better linting I wen't through every single file... and since I was updating components as well as docs I have few thoughts about implementation, styling, usage of props, errors and the other more or less opinionated things...

Here is the "raw" list of issues I found during the above process... some would require separate tickets/discussions... some just decision which way to go with them.

When responding please use "Issue number" and if we'll create dedicated tickets... I'll edit this message to link them properly.

1. paragraph should have mb3 as default with mb-0 for the last one - WIP: Feature/paragraph updates #257
2. heading should be H element
3. link should be <router-link> if prop to is set
4. images shouldn't be linked from other repos like flowbite-svelte
5. no need for props for things that can be achieved by tailwind class (align, size)
6. review and remove /* eslint-disable
7. avatar status is not visible when image is used - WIP: Feature/avatar updates #258
8. avatar-stack-counter shouldn't be a link
9. type check for avatar-stack-counter total doesn't work
10. breadcrumb-item should be used internally and breadcrumbs component should accept array
11. breadcrumb-item should be <router-link> if prop to is set
12. <Accordion :open-first-item="false"> should be just <Accordion first-item-closed>
13. button loading state should replace content without affecting button size
14. carousel component's slide prop is not working
15. carousel interval prop should not be slide dependent
16. dropdown placements right and left are working on second click (bad position on first one)
17. should dropdown arrow be aligned with dropdown placement?
18. fwb-list-group-item hover only makes sense if it's clickable (should accept href or to)
19. could pagination use button-group internally?
20. disabled pagination button should not have hover effect ("Previous" / "Next") FIX: refactor: Update disabledClasses in FwbPagination.vue #319
21. besideText slot in rating component should have default styling
22. rating component should be able to manage floats
23. it should be possible to have rating count without a link
24. spinner size should not be based on fixed classes but something like: w-${size} h-${size}
25. tabs directive should be boolean and named like directive-show (easier DX)
26. click:pane should pass through event data
27. Toast component type="empty" shouldn't be needed (without-icon would make more sense and allow for more flexibility)
28. example for Interactive Toast doesn't work without flowbite-themable component
29. Toasts are lacking one of the main functionality (dynamic dysplaying in predefined positions)
30. "hovered" Tooltip dissapears on click
31. file-input should have accept prop to allow for file extensions filtering
32. file-input with deopzone="true" doesn't accept multiple files
33. select have conflicting styles
34. select dropdown is not always styled properly ("placeholder sometimes disappears")
35. used in textarea comment example <fwb-button color=""> or <fwb-button color> looks like a hack and needs to be fixed
36. checkbox label could heve class select-none so it's not selectable on multiple clicks
37. checkbox and radio lists should be created by dedicated components
38. horizontal version of checkboxes and radios list should be option of their group components
39. in range component label's for attribute can't be hard-coded
40. table component should not require building table manually... (https://bootstrap-vue.org/docs/components/table is a good example)
41. alert#additional-content could use fwb-button instead of HTML one
42. "Carousel with slide animation" slide animation doesn't work
43. we should unify sizes... sometime we have prop sizewith different option.. and sometimes we have dedicated prop like large (pagination)
44. Failed to resolve component: router-link in Sidebar component (we need to add vue router dependency for that to work)
45. file upload component button is too dark in light theme

[cogor]

2. Done (Components renaming #225)

[Sqrcz]

1. redy for review in Feature/paragraph updates #257

[Sqrcz]

7. ready for review in Feature/avatar updates #258

[Sqrcz]

20. Fixed in refactor: Update disabledClasses in FwbPagination.vue #319