Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove volumes on down #910

Merged
merged 7 commits into from
Mar 7, 2023
Merged

remove volumes on down #910

merged 7 commits into from
Mar 7, 2023

Conversation

cgoodsirsmyth-pp
Copy link
Contributor

@cgoodsirsmyth-pp cgoodsirsmyth-pp commented Mar 2, 2023 •
edited by mdelapenya
Loading

What does this PR do?

Optionally cleans up volumes when using compose.Down()

Why is it important?

Cleaning up after your tests is important. ;)

Related issues

@cgoodsirsmyth-pp cgoodsirsmyth-pp requested a review from a team as a code owner March 2, 2023 18:38
@netlify
Copy link

netlify bot commented Mar 2, 2023 •
edited
Loading

✅ Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit cb4234e
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/64077e35bb599200087c4729
😎 Deploy Preview https://deploy-preview-910--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mdelapenya mdelapenya self-assigned this Mar 2, 2023
@mdelapenya mdelapenya added chore Changes that do not impact the existing functionality compose Docker Compose. labels Mar 2, 2023
mdelapenya
mdelapenya approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for making Testcontainers for Go awesome!

mdelapenya
mdelapenya requested changes Mar 4, 2023
View reviewed changes
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a second look, and I think we are only missing this last change before merging the PR

Thanks again for your work here

modules/compose/compose_api_test.go Show resolved Hide resolved
modules/compose/compose_api_test.go Outdated Show resolved Hide resolved
@mdelapenya mdelapenya mentioned this pull request Mar 6, 2023
Merged
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.7% 0.7% Duplication

mdelapenya
mdelapenya approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your time here, nice contribution!

@mdelapenya mdelapenya merged commit 8767d82 into testcontainers:main Mar 7, 2023
@mdelapenya mdelapenya added enhancement New feature or request and removed chore Changes that do not impact the existing functionality labels Mar 7, 2023
@cgoodsirsmyth-pp cgoodsirsmyth-pp deleted the 644-remove-volumes-on-down branch March 7, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdelapenya mdelapenya mdelapenya approved these changes

Assignees

@mdelapenya mdelapenya

Labels
compose Docker Compose. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Remove created volumes on "down"
2 participants
@cgoodsirsmyth-pp @mdelapenya