Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Remove created volumes on "down" #644

Closed
andyautida14 opened this issue Nov 26, 2022 · 1 comment · Fixed by #910
Closed

[Enhancement]: Remove created volumes on "down" #644

andyautida14 opened this issue Nov 26, 2022 · 1 comment · Fixed by #910
Labels
enhancement New feature or request

Comments

@andyautida14
Copy link

Proposal

When calling the Down() method of the LocalDockerCompose created through NewLocalDockerCompose(), volumes created when "upping" the instance are deleted through the --volumes option:

return executeCompose(dc, []string{"down", "--remove-orphans", "--volumes"})

It would be nice to have that behavior on ComposeStack.Down() created through NewDockerCompose() as well. I believe this can be easily achieved by adding Volumes: true on the following line:

DownOptions: api.DownOptions{

BTW, I thank all the contributors of this awesome library. It's been really useful to me.

@andyautida14 andyautida14 added the enhancement New feature or request label Nov 26, 2022
@mdelapenya
Copy link
Member

Would you mind contributing it? I think it would be simple to review indeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants