Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Region fix #44

Merged
merged 3 commits into from
Nov 19, 2019
Merged

Region fix #44

merged 3 commits into from
Nov 19, 2019

Conversation

ocervell
Copy link
Contributor

I enabled autoscaling on the module and noticed that it required the region field as well.

I enabled autoscaling on the module and noticed that it required the region field as well.
@ocervell ocervell requested a review from morgante November 19, 2019 17:19
@ocervell
Copy link
Contributor Author

Sorry, I hope this is the last one ;)

@morgante
Copy link
Contributor

@ocervell Would you mind fixing the linting issue while you're at it?

--- old/modules/mig_with_percent/main.tf
+++ new/modules/mig_with_percent/main.tf
@@ -82,7 +82,7 @@
 
   lifecycle {
     create_before_destroy = "true"
-    ignore_changes = ["distribution_policy_zones"]
+    ignore_changes        = ["distribution_policy_zones"]
   }
 }

@ocervell
Copy link
Contributor Author

@morgante done !

@morgante
Copy link
Contributor

Hmm looks like the linter is still failing. Could you get it passing locally? (With make docker_test_lint).

F
ix linting errors
@ocervell
Copy link
Contributor Author

Passing locally now.

@morgante morgante merged commit bc002ef into master Nov 19, 2019
@ocervell ocervell deleted the ocervell-patch-2 branch November 20, 2019 10:14
aaron-lane pushed a commit that referenced this pull request Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants