Allow setting region without updating provider #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if we work in a specific region we'll have to specify it in our google provider. This change allows to keep a region-agnostic provider and simply pass the region to the `data.google_compute_zones.available` resource.
morgante
approved these changes
Nov 14, 2019
ocervell
pushed a commit
to terraform-google-modules/terraform-google-lb-internal
that referenced
this pull request
Nov 19, 2019
Same problem as terraform-google-modules/terraform-google-vm#42 but for the ILB module: Currently if we work in a specific region we'll have to specify it in our google provider. This change allows to keep a region-agnostic provider and simply pass the region to the data.google_compute_zones.available resource.
aaron-lane
pushed a commit
that referenced
this pull request
Nov 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if we work in a specific region we'll have to specify it in our google provider.
This change allows to keep a region-agnostic provider and simply pass the region to the
data.google_compute_zones.availableresource.