Add test for sandbox #280
Closed
Add test for sandbox #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulpalamarchuk
force-pushed
the
add_sanbox_test
branch
4 times, most recently
from
c61ed6b to
6e8ad97
Compare
paulpalamarchuk
force-pushed
the
add_sanbox_test
branch
from
6e8ad97 to
eda0c98
Compare
kopachevsky
reviewed
Oct 17, 2019
| @@ -21,10 +21,6 @@ output "project_id" { | |||
| value = var.project_id | |||
| } | |||
|
|
|||
| output "credentials_path" { | |||
There was a problem hiding this comment.
why crednetial_path removed, is it related to PR?
There was a problem hiding this comment.
It's unnecessary output
test/setup/main.tf
Outdated
| org_id = var.org_id | ||
| folder_id = var.folder_id | ||
| billing_account = var.billing_account | ||
| name = "ci-gke-${random_id.random_project.hex}" |
There was a problem hiding this comment.
why random_project_id is not good enough?
paulpalamarchuk
force-pushed
the
add_sanbox_test
branch
from
eda0c98 to
daaf03f
Compare
paulpalamarchuk
force-pushed
the
add_sanbox_test
branch
from
daaf03f to
6db2c5d
Compare
paulpalamarchuk
force-pushed
the
add_sanbox_test
branch
from
6db2c5d to
b3c8466
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sanbox_configtonode_poolresouce (Fix Add sandbox flag for node-pools #240)