Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sandbox flag for node-pools #240

Closed
lesv opened this issue Aug 20, 2019 · 2 comments · Fixed by #241 or #286
Closed

Add sandbox flag for node-pools #240

lesv opened this issue Aug 20, 2019 · 2 comments · Fixed by #241 or #286
Assignees
@paulpalamarchuk
Labels
enhancement New feature or request

Comments

@lesv
Copy link

lesv commented Aug 20, 2019

It would be nice if support for the sandbox was able to be enabled. docs
@morgante
Copy link
Contributor

morgante commented Aug 20, 2019 •
edited
Loading

Looks like this corresponds to the sandbox_config param: https://www.terraform.io/docs/providers/google/r/container_cluster.html#sandbox_type

We should:

  1. Add a new boolean variable sandbox_enabled which defaults to false (only on beta clusters).
  2. If sandbox_enabled is true, inject the sandbox_config block on the cluster (with gvisor as the sandbox type). Note that this should be done using a dynamic block, like how workload identity was handled.

@morgante morgante changed the title add sandbox flag for node-pools Add sandbox flag for node-pools Aug 20, 2019
@paulpalamarchuk paulpalamarchuk self-assigned this Aug 21, 2019
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-kubernetes-engine that referenced this issue Aug 21, 2019
@paulpalamarchuk
Add flag to enable GKE Sandbox
3efa2f3 
 * Add `sandbox_enabled` variable to use Sandbox (Fixes terraform-google-modules#240)
@paulpalamarchuk paulpalamarchuk mentioned this issue Aug 21, 2019
Merged
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-kubernetes-engine that referenced this issue Aug 21, 2019
@paulpalamarchuk
Add flag to enable GKE Sandbox
aa70e8a 
 * Add `sandbox_enabled` variable to use Sandbox (Fixes terraform-google-modules#240)
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-kubernetes-engine that referenced this issue Aug 23, 2019
@paulpalamarchuk
Add flag to enable GKE Sandbox
e88d26b 
 * Add `sandbox_enabled` variable to use GKE Sandbox (Fixes terraform-google-modules#240)
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-kubernetes-engine that referenced this issue Aug 27, 2019
@paulpalamarchuk
Add flag to enable GKE Sandbox
2ccc0f3 
 * Add `sandbox_enabled` variable to use GKE Sandbox (Fixes terraform-google-modules#240)
@morgante morgante mentioned this issue Aug 28, 2019
Closed
@paulpalamarchuk
Copy link
Contributor

sandbox_config has to be moved to the node_pool resource, because "GKE Sandbox can't be enabled for the default node pool"

paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-kubernetes-engine that referenced this issue Oct 14, 2019
@paulpalamarchuk
Add test for sandbox
79d8b65 
 * Moved `sanbox_config` to `node_pool` resouce (Fix terraform-google-modules#240)
 * Created test for sandbox (Fix terraform-google-modules#252)
 * Updated docker image version
@paulpalamarchuk paulpalamarchuk mentioned this issue Oct 14, 2019
Closed
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-kubernetes-engine that referenced this issue Oct 14, 2019
@paulpalamarchuk
Add test for sandbox
6420311 
 * Moved `sanbox_config` to `node_pool` resouce (Fix terraform-google-modules#240)
 * Created test for sandbox (Fix terraform-google-modules#252)
 * Updated docker image version
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-kubernetes-engine that referenced this issue Oct 14, 2019
@paulpalamarchuk
Add test for sandbox
8764620 
 * Moved `sanbox_config` to `node_pool` resouce (Fix terraform-google-modules#240)
 * Created test for sandbox (Fix terraform-google-modules#252)
 * Updated docker image version
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-kubernetes-engine that referenced this issue Oct 14, 2019
@paulpalamarchuk
Add test for sandbox
c61ed6b 
 * Moved `sanbox_config` to `node_pool` resouce (Fix terraform-google-modules#240)
 * Created test for sandbox (Fix terraform-google-modules#252)
 * Updated docker image version
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-kubernetes-engine that referenced this issue Oct 14, 2019
@paulpalamarchuk
Add test for sandbox
6e8ad97 
 * Moved `sanbox_config` to `node_pool` resouce (Fix terraform-google-modules#240)
 * Created test for sandbox (Fix terraform-google-modules#252)
 * Updated docker image version
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-kubernetes-engine that referenced this issue Oct 14, 2019
@paulpalamarchuk
Add test for sandbox
eda0c98 
 * Moved `sanbox_config` to `node_pool` resouce (Fix terraform-google-modules#240)
 * Created test for sandbox (Fix terraform-google-modules#252)
 * Updated docker image version
@aaron-lane aaron-lane added the enhancement New feature or request label Oct 14, 2019
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-kubernetes-engine that referenced this issue Oct 17, 2019
@paulpalamarchuk
Add test for sandbox
daaf03f 
 * Moved `sanbox_config` to `node_pool` resouce (Fix terraform-google-modules#240)
 * Created test for sandbox (Fix terraform-google-modules#252)
 * Updated docker image version
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-kubernetes-engine that referenced this issue Oct 18, 2019
@paulpalamarchuk
Moved sanbox_config to node_pool resouce (Fix terraform-google-mo…
6db2c5d 
…dules#240)
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-kubernetes-engine that referenced this issue Oct 18, 2019
@paulpalamarchuk
Moved sanbox_config to node_pool resouce (Fix terraform-google-mo…
b3c8466 
…dules#240)
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-kubernetes-engine that referenced this issue Oct 18, 2019
@paulpalamarchuk
Moved sanbox_config to node_pool resouce (Fix terraform-google-module…
a72264e 
…s#240)
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-kubernetes-engine that referenced this issue Oct 18, 2019
@paulpalamarchuk
Moved sanbox_config to node_pool resource (Fix terraform-google-modul…
a0f5f7b 
…es#240)
@paulpalamarchuk paulpalamarchuk mentioned this issue Oct 18, 2019
Merged
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this issue Jul 15, 2024
@paulpalamarchuk
Add flag to enable GKE Sandbox
2ff55be 
 * Add `sandbox_enabled` variable to use GKE Sandbox (Fixes terraform-google-modules#240)
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this issue Jul 15, 2024
@paulpalamarchuk
Moved sanbox_config to node_pool resource (Fix terraform-google-modul…
82653c1 
…es#240)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulpalamarchuk paulpalamarchuk

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
4 participants
@lesv @morgante @aaron-lane @paulpalamarchuk