fastsync/rpc: add TotalSyncedTime & RemainingTime to SyncInfo in /status RPC #6620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayT106
requested review from
alexanderbez,
cmwaters,
ebuchman,
tessr and
tychoish
as code owners
alexanderbez
suggested changes
Jun 26, 2021
JayT106
force-pushed
the
fastSync-time-metrics
branch
2 times, most recently
from
286514f to
f273668
Compare
Codecov Report
@@ Coverage Diff @@
## master #6620 +/- ##
==========================================
- Coverage 65.99% 60.92% -5.07%
==========================================
Files 234 297 +63
Lines 20269 28210 +7941
==========================================
+ Hits 13376 17187 +3811
- Misses 5825 9291 +3466
- Partials 1068 1732 +664
|
cmwaters
suggested changes
Jun 29, 2021
cmwaters
changed the title
JayT106
changed the title
JayT106
force-pushed
the
fastSync-time-metrics
branch
2 times, most recently
from
eb53e88 to
fb69406
Compare
cmwaters
approved these changes
Jun 30, 2021
I think it's a good idea. Should we make a different PR for addressing the state sync info? |
tychoish
suggested changes
Jun 30, 2021
|
@JayT106 yes, sure, we can tackle that in a separate PR 👍 |
JayT106
force-pushed
the
fastSync-time-metrics
branch
from
822e351 to
79340b6
Compare
tychoish
reviewed
Jul 6, 2021
|
|
||
| import "testing" | ||
|
|
||
| func TestDefaultValue(t *testing.T) { |
There was a problem hiding this comment.
I might also add a few tests that attempt to modify the structure a bunch of times from multiple threads, in a way that the race detector would catch. The interesting part of this type is that it's thread safe/atomic, not that it's a boolean, and it would be nice if the tests would help provide confidence there.
tychoish
approved these changes
Jul 6, 2021
JayT106
force-pushed
the
fastSync-time-metrics
branch
from
cbf899d to
d270f0f
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3365 once #6619 merged