Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Information related to remaining blocks need to be synced and remaining time #3365

Closed
ironman0x7b2 opened this issue Feb 28, 2019 · 18 comments · Fixed by #6620
Closed

Information related to remaining blocks need to be synced and remaining time #3365

ironman0x7b2 opened this issue Feb 28, 2019 · 18 comments · Fixed by #6620
Assignees
@JayT106
Labels
C:sync Component: Fast Sync, State Sync good first issue Contributions Welcome!! T:ux Type: Issue or Pull Request related to developer experience

Comments

@ironman0x7b2
Copy link

Hi,

It will be great if we have the following features

  • Way to know the remaining blocks that need to be synced
  • Way to know the total and remaining time it takes to sync the whole blockchain
  • Emitting an event after syncing the whole blockchain
@ironman0x7b2 ironman0x7b2 changed the title Information related to remaining blocks need to synced and time Information related to remaining blocks need to be synced and remaining time Feb 28, 2019
@ebuchman ebuchman added C:sync Component: Fast Sync, State Sync user labels Feb 28, 2019
@ebuchman
Copy link
Contributor

Way to know the remaining blocks that need to be synced

This is output in the logs as max_peer_height

Way to know the total and remaining time it takes to sync the whole blockchain

Not sure this is really possible to know

Emitting an event after syncing the whole blockchain

We could add an event for when we switch to consensus, good idea. Also see #2498.

@ebuchman
Copy link
Contributor

Should we add max_peer_height to the /status endpoint?

@ironman0x7b2
Copy link
Author

ironman0x7b2 commented Mar 1, 2019 •
edited
Loading

Should we add max_peer_height to the /status endpoint?

Yes.

@ebuchman ebuchman added help wanted good first issue Contributions Welcome!! labels Mar 2, 2019
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 200.0 DAI (200.0 USD @ $1.0/DAI) attached to it.

@gitcoinbot
Copy link

@iamonuwa Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

8 similar comments
@gitcoinbot
Copy link

@iamonuwa Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@iamonuwa Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@iamonuwa Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@iamonuwa Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@iamonuwa Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@iamonuwa Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@iamonuwa Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@iamonuwa Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@vlasveld vlasveld mentioned this issue Jan 9, 2020
Closed
8 tasks
@vlasveld
Copy link

vlasveld commented Jan 9, 2020

Trying to get my bearings:)

Am I missing an interface that could be used instead? I assume the Switch or the Reporters aren't intended for such messages. Also, initially I aimed at moving MaxPeerHeight to the consensusReactor, but as it's about a self-reported value from peers, it doesn't really belong there..

Also, about triggering an event: any data that would be relevant to include in an event? Node's block height is the only data I could think of. Unless the event should also be triggered when moving back to fastSync: then it could perhaps contain a syncState (fastSync or Consensus)

@tac0turtle tac0turtle added T:ux Type: Issue or Pull Request related to developer experience and removed help wanted labels Feb 25, 2020
@melekes
Copy link
Contributor

melekes commented Mar 11, 2020

Some work was done here #4296

@JayT106 JayT106 mentioned this issue Jun 23, 2021
Merged
@JayT106
Copy link
Contributor

JayT106 commented Jun 23, 2021

@marbar3778 could you assign this issue to me? also the issue #2498? thanks!

@tac0turtle
Copy link
Contributor

@marbar3778 could you assign this issue to me? also the issue #2498? thanks!

assigned in this one. I think you need to leave a comment in the other one in order for me to assign it.

@JayT106
Copy link
Contributor

JayT106 commented Jun 23, 2021

@marbar3778 could you assign this issue to me? also the issue #2498? thanks!

assigned in this one. I think you need to leave a comment in the other one in order for me to assign it.

Cool. I left a comment in the other one.

mergify bot pushed a commit that referenced this issue Jun 24, 2021
@JayT106
rpc: add max peer block height into /status rpc call (#6610)
2cc8725 
use  `maxPeerBlockHeight` information to show the current network's best height.

Closes #3983
Relate to #3365

ref: the`highestBlock` in the response of `eth.isSyncing` call
https://web3js.readthedocs.io/en/v1.3.4/web3-eth.html#issyncing
This was referenced Jun 24, 2021
Merged
Merged
mergify bot pushed a commit that referenced this issue Jul 20, 2021
@JayT106
fastsync/event: emit fastsync status event when switching consensus/f…
c4f77ab 
…astsync (#6619)

closes #2498 
solves part of #3365

Note: difficult to test the event emit in SwitchToFastSync part, might need to change `stateSyncReactor` to an interface in the `nodeImpl` struct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JayT106 JayT106

Labels
C:sync Component: Fast Sync, State Sync good first issue Contributions Welcome!! T:ux Type: Issue or Pull Request related to developer experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fastsync/rpc: add TotalSyncedTime & RemainingTime to SyncInfo in /status RPC JayT106/tendermint
7 participants
@melekes @ebuchman @vlasveld @JayT106 @tac0turtle @gitcoinbot @ironman0x7b2