Cleanup cluster resources when test fails

[dibyom]

Fixes #495

Signed-off-by: Dibyo Mukherjee [email protected]

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices

See the contribution guide for more details.

Release Notes

[ncskier]

I tested this out (using Docker for Desktop) and it didn't seem to clean up the cluster-wide resources when I interrupted the test with Ctrl+C or when I added a t.Fatal()to make the test fail 😕I'm not sure why though... did it work for you when you tested this @dibyom ?

Also, looks like the build test is failing because of gosimple:

I0326 02:58:02.072] pkg/apis/triggers/v1alpha1/event_listener_validation.go:65:31: S1039: unnecessary use of fmt.Sprintf (gosimple)
I0326 02:58:02.072] return apis.ErrMissingField(fmt.Sprintf("template.name"))

[ncskier]

Hm, I just tested again, and the cleanup worked when I put a t.Fatal() in the test. However, the cleanup still doesn't seem to work when I interrupt the test with Ctrl+C.

[dibyom]

The cleanup should work Ctrl + C as well due to
knativetest.CleanupOnInterrupt(func() { cleanup(t, c, namespace) }, t.Logf)

Just tried this out on my local environment (linux machines, cluster is GKE) and the test cleaned up fine
`

[ncskier]

Ok. Yeah, not sure why the Ctrl+C isn't working for me, but at least it cleans up when the test fails. So, this PR definitely addresses the issue 👍
/lgtm
/approve

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncskier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ncskier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ncskier]

/test pull-tekton-triggers-build-tests