Switch API group for triggers to triggers.tekton.dev

[dibyom]

Changes

BREAKING CHANGE: Users will have to delete, and recreate
resources after updating its API group.

Fixes #332

Signed-off-by: Dibyo Mukherjee [email protected]

TODO:

• Fix e2e test
• Allow creating v1beta1 resources #490

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices

See the contribution guide for more details.

Release Notes

All Triggers resources now use the triggers.tekton.dev API Group.

BREAKING CHANGE: Users will have to delete, and recreate
resources after updating its API group.

[dibyom]

/hold

Ready for review but need to validate and document upgrade paths

[dibyom]

Tried this out locally.

• Users will have to change the role resources for their ELs on their own.
• Will write up a script in a followup that can change any existing old types to the new ones and then delete the old CRDs.

/hold cancel

[ncskier]

Thanks for making these changes @dibyom! Looks great for the most part.

I think that I found a few places where your find & replace changed something that it shouldn't have. Also, I left a comment about the changes to the e2e tests... are those necessary for this PR? I don't want them to get lost in this commit since so many files have been modified.

[dibyom]

/test pull-tekton-triggers-build-tests

[ncskier]

Thanks for the updates @dibyom! Just a couple more questions/comments.

Also, I did a search for apiVersion: tekton.dev and found a couple places where we didn't update to triggers.tekton.dev (we don't use the update-docs scripts in these locations 😕)

• https://github.com/tektoncd/triggers/blob/master/docs/eventlisteners.md (8 instances)
• https://github.com/tektoncd/triggers/blob/master/docs/triggerbindings.md (5 instances)

---

Also, should https://github.com/tektoncd/triggers/blob/master/docs/getting-started/triggers.yaml#L16 be v1beta1?

[ncskier]

/lgtm

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncskier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ncskier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment