Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix EL Status URL for kubernetesresource.serviceport #1632

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Fix EL Status URL for kubernetesresource.serviceport #1632

merged 1 commit into from
Aug 24, 2023

Conversation

khrm
Copy link
Contributor

@khrm khrm commented Aug 18, 2023 •
edited
Loading

Fixes Eventlistener's status.address.url port not matching specified spec.resources.kubernetesresource.serviceport. Previously, it only showed the default port.

Fixes #1473

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Aug 18, 2023
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 18, 2023
khrm
khrm commented Aug 18, 2023
View reviewed changes
Copy link
Contributor Author

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/kind bug

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 18, 2023
@khrm
Fix EL Status URL for kubernetesresource.serviceport
9407c61 
Fixes Eventlistener's status.address.url port not matching specified
spec.resources.kubernetesresource.serviceport. Previously, it only
showed default port.
@khrm
Copy link
Contributor Author

khrm commented Aug 18, 2023

/test pull-tekton-triggers-integration-tests

1 similar comment
@khrm
Copy link
Contributor Author

khrm commented Aug 18, 2023

/test pull-tekton-triggers-integration-tests

@khrm khrm added this to the Triggers v0.25 milestone Aug 23, 2023
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2023
@savitaashture
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2023
@tekton-robot tekton-robot merged commit 33af25d into tektoncd:main Aug 24, 2023
@khrm khrm deleted the b/elStatusURL branch August 24, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibyom dibyom dibyom approved these changes

@iancoffey iancoffey Awaiting requested review from iancoffey

@ncskier ncskier Awaiting requested review from ncskier

Assignees

@savitaashture savitaashture

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
Triggers v0.25
Development

Successfully merging this pull request may close these issues.

Eventlistener status.address.url port does not match spec.resources.kubernetesresource.serviceport
4 participants
@khrm @tekton-robot @savitaashture @dibyom