Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eventlistener status.address.url port does not match spec.resources.kubernetesresource.serviceport #1473

Closed
lbernick opened this issue Oct 31, 2022 · 10 comments · Fixed by #1632
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@lbernick
Copy link
Member

Expected Behavior

Eventlistener status.address should accurately reflect the service where the EventListener can be reached.

Actual Behavior; Steps to Reproduce the Problem

EventListener spec:

apiVersion: triggers.tekton.dev/v1beta1
kind: EventListener
metadata:
  name: github-listener
  namespace: dogfood
spec:
  triggers:
    - name: github-listener
      interceptors:
        - name: "only for main branch"
          ref:
            name: "cel"
          params:
            - name: "filter"
              value: "body.ref == 'refs/heads/main'"
      template:
        ref: github-template
  serviceAccountName: eventlistener-sa
  resources:
    kubernetesResource:
      serviceType: ClusterIP
      servicePort: 80
$ k get svc -n dogfood
NAME                                  TYPE           CLUSTER-IP    EXTERNAL-IP                                         PORT(S)                                              AGE
el-github-listener                    ClusterIP      10.92.3.40    <none>                                              80/TCP,9000/TCP

^ The service is created on the port I specified.

$ k get el github-listener -n dogfood -o yaml
apiVersion: triggers.tekton.dev/v1beta1
kind: EventListener
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"triggers.tekton.dev/v1beta1","kind":"EventListener","metadata":{"annotations":{},"name":"github-listener","namespace":"dogfood"},"spec":{"resources":{"kubernetesResource":{"servicePort":80,"serviceType":"ClusterIP"}},"serviceAccountName":"eventlistener-sa","triggers":[{"interceptors":[{"name":"only for main branch","params":[{"name":"filter","value":"body.ref == 'refs/heads/main'"}],"ref":{"name":"cel"}}],"name":"github-listener","template":{"ref":"github-template"}}]}}
  creationTimestamp: "2022-10-31T20:56:43Z"
  generation: 2
  name: github-listener
  namespace: dogfood
  resourceVersion: "76308866"
  uid: 08f2384a-e5a3-4590-97ea-e243bd17f596
spec:
  namespaceSelector: {}
  resources:
    kubernetesResource:
      servicePort: 80
      serviceType: ClusterIP
      spec:
        template:
          metadata:
            creationTimestamp: null
          spec:
            containers: null
  serviceAccountName: eventlistener-sa
  triggers:
  - interceptors:
    - name: only for main branch
      params:
      - name: filter
        value: body.ref == 'refs/heads/main'
      ref:
        kind: ClusterInterceptor
        name: cel
    name: github-listener
    template:
      ref: github-template
status:
  address:
    url: http://el-github-listener.dogfood.svc.cluster.local:8080
  conditions:
  - lastTransitionTime: "2022-10-31T20:56:44Z"
    message: Deployment has minimum availability.
    reason: MinimumReplicasAvailable
    status: "True"
    type: Available
  - lastTransitionTime: "2022-10-31T20:56:44Z"
    message: Deployment exists
    status: "True"
    type: Deployment
  - lastTransitionTime: "2022-10-31T20:56:44Z"
    message: ReplicaSet "el-github-listener-55d97c8d47" has successfully progressed.
    reason: NewReplicaSetAvailable
    status: "True"
    type: Progressing
  - lastTransitionTime: "2022-10-31T20:56:44Z"
    message: EventListener is ready
    status: "True"
    type: Ready
  - lastTransitionTime: "2022-10-31T20:56:44Z"
    message: Service exists
    status: "True"
    type: Service
  configuration:
    generatedName: el-github-listener

^ EventListener spec has the correct kubernetesresources.serviceport, but status.address.url is incorrect.

Additional Info

  • Kubernetes version:

    Output of kubectl version:

Client Version: version.Info{Major:"1", Minor:"25", GitVersion:"v1.25.2", GitCommit:"5835544ca568b757a8ecae5c153f317e5736700e", GitTreeState:"clean", BuildDate:"2022-09-21T14:25:45Z", GoVersion:"go1.19.1", Compiler:"gc", Platform:"darwin/arm64"}
Kustomize Version: v4.5.7
Server Version: version.Info{Major:"1", Minor:"24", GitVersion:"v1.24.3-gke.200", GitCommit:"58cd50d1c2a9028cfb92baf62cc0b678ef751532", GitTreeState:"clean", BuildDate:"2022-07-20T09:23:47Z", GoVersion:"go1.18.3b7", Compiler:"gc", Platform:"linux/amd64"}
  • Tekton Pipeline version:
$ tkn version
Client version: 0.26.0
Pipeline version: devel
Triggers version: devel
@lbernick lbernick added the kind/bug Categorizes issue or PR as related to a bug. label Oct 31, 2022
@tekton-robot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 29, 2023
@lbernick
Copy link
Member Author

/remove-lifecycle stale

@tekton-robot tekton-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 30, 2023
@khrm khrm self-assigned this Feb 22, 2023
@tekton-robot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 23, 2023
@tekton-robot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 22, 2023
@tekton-robot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@khrm
Copy link
Contributor

khrm commented Jul 24, 2023

/reopen

@tekton-robot tekton-robot reopened this Jul 24, 2023
@tekton-robot
Copy link

@khrm: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-project-automation github-project-automation bot moved this from Done to In Progress in Tekton Community Roadmap Jul 24, 2023
@khrm
Copy link
Contributor

khrm commented Jul 24, 2023

/remove-lifecycle rotten

@tekton-robot tekton-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jul 24, 2023
@khrm
Copy link
Contributor

khrm commented Jul 24, 2023

/lifecycle frozen

@tekton-robot tekton-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Jul 24, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Tekton Community Roadmap Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants