Next batch of editorial issues #2922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is one step towards breaking the annoying circular import between calendar.mjs and ecmascript.mjs.
This observable call occurred while building an error message. It shouldn't be there according to the spec.
roundedFractionalDays/roundedDaysRemainder isn't needed, and would be more of a hassle for implementations to calculate anyway. Closes: #2889
There is already a test262 case that tests throwing here: test/built-ins/Temporal/ZonedDateTime/prototype/until/roundingincrement-addition-out-of-range.js Thanks to Anba for spotting this. Closes: #2891
Thanks to Anba for spotting this.
These weren't used anymore after removing Now.plainDate/plainDateTime/ zonedDateTime. Thanks to Anba for spotting this.
justingrant
reviewed
Aug 8, 2024
justingrant
approved these changes
Aug 8, 2024
These arguments aren't optional in the corresponding spec text AOs either.
This was referenced Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best reviewed commit by commit. Explanations in each commit message. Closes several issues opened by @anba.