-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meta: bump ecmarkup to 15.0.0 and apply new formatting/lint rules #2901
Conversation
@@ -29911,7 +29911,7 @@ <h1>Function ( _p1_, _p2_, … , _pn_, _body_ )</h1> | |||
<p>This function performs the following steps when called:</p> | |||
<emu-alg> | |||
1. Let _C_ be the active function object. | |||
1. Let _args_ be the _argumentsList_ that was passed to this function by [[Call]] or [[Construct]]. | |||
1. [declared="argumentsList"] Let _args_ be the _argumentsList_ that was passed to this function by [[Call]] or [[Construct]]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI see #2902
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
b086396
to
f3bc5bc
Compare
1fbe3fb
to
69197b6
Compare
This now incorporates changes necessary to make #2902 pass. It also adds a new marked non-obvious declaration for an alias introduced in #2781 (in a fixup commit, which should get squashed into the "mark certain non-obvious variable declarations" commit when landing). It's ready to go as soon as #2896 lands, and will then un-block #2902. |
f3bc5bc
to
cf1ea07
Compare
69197b6
to
0090daf
Compare
Depends on #2896, and is based on that branch.
I recommend reviewing commits individually, and commits should land individually.
The "Markup: replace HTML entities" commit was generated by running
npm run format
; no manual changes were applied. Sidebar: we sure do have a lot of fancy quote marks.The "Markup: mark certain non-obvious variable declarations" commit is necessary to get the linter's new "variables must be defined" lint to pass; the ten lines it touches make use of variables in non-obvious ways that I didn't want to teach the linter about.
This has landed and will inevitably cause merge conflicts with almost everything, but fear not, you don't need to deal with it manually. To rebase a branch onto this, you can use the following commands:
This splits up the rebase into 1) everything before the formatter was applied, 2) the formatter, which will be done for you, 3) everything after the formatter. any conflicts in parts 1 and 3 you will need to handle manually, just like you would in the absence of the formatter (or feel free to ask the editors for help).