Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check if we can get away with keeping the old deployment minima #22

Merged
merged 3 commits into from
Nov 19, 2024
Merged

check if we can get away with keeping the old deployment minima #22

merged 3 commits into from
Nov 19, 2024

Conversation

tayloraswift
Copy link
Owner

No description provided.

@tayloraswift tayloraswift reopened this Nov 19, 2024
@tayloraswift tayloraswift mentioned this pull request Nov 19, 2024
Merged
@tayloraswift tayloraswift marked this pull request as draft November 19, 2024 22:41
@tayloraswift
Copy link
Owner Author

so it looks like the problem here is even when we apply the required @available guards, the macro-generated code from Swift Testing doesn’t preserve them correctly

@tayloraswift tayloraswift marked this pull request as ready for review November 19, 2024 23:19
@tayloraswift
Copy link
Owner Author

okay, this scales really poorly with Swift Testing’s one-function-per-test model, but it compiles!

@tayloraswift tayloraswift merged commit ea0b9fc into master Nov 19, 2024
8 checks passed
@tayloraswift tayloraswift deleted the test-lowering-deployment-minima branch November 19, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tayloraswift