Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: upgrade setup-go to v4 #1408

Closed
wants to merge 1 commit into from
Closed

CI: upgrade setup-go to v4 #1408

wants to merge 1 commit into from

Conversation

dolmen
Copy link
Collaborator

@dolmen dolmen commented Jul 5, 2023

Summary

Upgrade CI to use setup-go v4

Motivation

Use latest features such as module cache.

@dolmen
Copy link
Collaborator Author

dolmen commented Jul 6, 2023

@SuperQ Could you review this?

@SuperQ
Copy link
Contributor

SuperQ commented Jul 6, 2023

LGTM, but maybe the test is flakey?

@dolmen dolmen self-assigned this Jul 6, 2023
@dolmen dolmen added the github_actions Pull requests that update GitHub Actions code label Jul 6, 2023
@dolmen dolmen force-pushed the actions-setupgov4 branch from b6c70b8 to 16f80b8 Compare July 6, 2023 11:23
@SuperQ
Copy link
Contributor

SuperQ commented Jul 6, 2023

So strange that the tests pass now.

@dolmen dolmen marked this pull request as draft July 6, 2023 13:13
@dolmen
Copy link
Collaborator Author

dolmen commented Jul 6, 2023

@SuperQ Note that I have merged a few PRs yesterday and I have rebased my branch.

@dolmen
Copy link
Collaborator Author

dolmen commented Oct 10, 2023

I had to merge #1451 instead, because I lack the permissions to merge my own MRs. 😭

@dolmen dolmen closed this Oct 10, 2023
@dolmen dolmen deleted the actions-setupgov4 branch March 5, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants