Test failures on go1.20 with v4, not on v3.2.0

[dolmen]

Description:

I'm a co-maintainer of Go module github.com/stretchr/testify, a major module in the Go ecosystem. I'm trying to migrate actions/setup-go from v3.2.0 to v4.

However, on v4 we get test failures with go1.20 which do not appear with setup-go v3.20.
See stretchr/testify#1408

I know that testify testing has concurrency issues (go test -race -count=100 reports failures on go1.20 on my machine), but I don't see how the changes mentioned in the changelog of setup-go (enable module cache) would affect us.

What changes appeared in v4 that could trigger this?

Note that testify is well known for having a circular dependency issue (for which I think I have a fix). Maybe that's related.

Action version:
Specify the action version

Platform:

• Ubuntu
• macOS
• Windows

Runner type:

• Hosted
• Self-hosted

Tools version:
go1.20

Repro steps:
A description with steps to reproduce the issue. If your have a public example or repo to share, please provide the link.

stretchr/testify#1408

Expected behavior:
Same test success/failure than with actions/setup-go v3.2.0

Actual behavior:
Tests failures.

[dolmen]

Cc: @SuperQ

[dusan-trickovic]

Hello, @dolmen ! Thank you for creating this issue, we will investigate it and see what can be done :)

[dmitry-shibanov]

Hello @dolmen. Could you please attach the link to the failed build? If it fails could you please try to disable cache: false for actions/setup-gov4

[SuperQ]

I think we already found the source of the issues, the test is flaky due to Go timer race. We have a proposed fix on our side in progress.

stretchr/testify#1412

As to why the new version of the action triggers this race more often, I have no idea. :)

[dmitry-shibanov]

Hello @SuperQ. Thank you for your response. In this case I'm going to close the issue. If you have any concerns feel free to ping us.