Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inaccessible exception constructor in proto2 generated code #222

Merged
merged 2 commits into from
Jun 2, 2022

Conversation

garyp
Copy link
Collaborator

@garyp garyp commented Jun 2, 2022

Also moved test protos and generated code into a separate sub-project, so that the generated test code is not part of the runtime sub-project and hence does not make use of APIs that are internal.

Fixes #221.

This ensures that the generated test code is not part of the `runtime`
sub-project and hence does not make use of APIs that are `internal`.
@garyp garyp requested a review from rahulreddym June 2, 2022 14:50
runtime/build.gradle.kts Show resolved Hide resolved
@garyp garyp force-pushed the bug/GH-221-required-fields-exception branch from 3d3525d to fb870a3 Compare June 2, 2022 19:51
@garyp garyp merged commit f182e42 into master Jun 2, 2022
@garyp garyp deleted the bug/GH-221-required-fields-exception branch June 2, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proto2 required fields validation throw exception which is not exposed
2 participants