Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proto2 required fields validation throw exception which is not exposed #221

Closed
TheBeastLT opened this issue May 29, 2022 · 3 comments · Fixed by #222
Closed

proto2 required fields validation throw exception which is not exposed #221

TheBeastLT opened this issue May 29, 2022 · 3 comments · Fixed by #222
Labels
bug Something isn't working component-codegen syntax-proto2
Milestone
0.14.1

Comments

@TheBeastLT
Copy link

Proto2 files that use the required keyword now have the generated code throw InvalidProtocolBufferException, which has its constructor marked as internal and the generated classes cannot be compiled.:

Cannot access '<init>': it is internal in 'InvalidProtocolBufferException'

Using latest 0.14.0 version.
@garyp garyp added this to the 0.14.1 milestone May 31, 2022
@garyp
Copy link
Collaborator

garyp commented May 31, 2022

Oh shoot. We missed this in our unit tests because they're part of the same project as the runtime, so they have access to internal members. I'll get a fix for this out in the next few days.

@garyp garyp mentioned this issue Jun 2, 2022
Merged
@garyp garyp closed this as completed in #222 Jun 2, 2022
garyp added a commit that referenced this issue Jun 2, 2022
@garyp
Merge pull request #222 from streem/bug/GH-221-required-fields-exception
f182e42 
Fix inaccessible exception constructor in proto2 generated code

Fixes #221
@TheBeastLT
Copy link
Author

@garyp Can we expect a patch release for this?

@garyp
Copy link
Collaborator

garyp commented Jun 3, 2022

@TheBeastLT Yep. We'll get 0.14.1 out with this fix today or Monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working component-codegen syntax-proto2
Projects
None yet
Milestone
0.14.1
Development

Successfully merging a pull request may close this issue.

Fix inaccessible exception constructor in proto2 generated code streem/pbandk
2 participants
@garyp @TheBeastLT