CSF-Tools: Remove prettier from printConfig #23766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasperpeulen
added
bug
ci:normal
patch:yes
ndelangen
reviewed
Aug 9, 2023
Comment on lines
-732
to
-735
| pretty = prettier.format(result.code, { | ||
| ...prettierConfig, | ||
| filepath: config.fileName ?? 'main.ts', | ||
| }); |
There was a problem hiding this comment.
@kasperpeulen can we detect the existence of node_modules/.bin/prettier and call it with the right arguments if it exists in a child_process?
That way we get the best of both worlds!?
ndelangen
approved these changes
Aug 9, 2023
|
@kasperpeulen regression fixed (top row, pink column). great job! 
|
storybook-bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
…m-csf-tools CSF-Tools: Remove prettier from printConfig (cherry picked from commit 8ee6798)
This was referenced Aug 9, 2023
Closed
storybook-bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
…m-csf-tools CSF-Tools: Remove prettier from printConfig (cherry picked from commit 8ee6798)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
…m-csf-tools CSF-Tools: Remove prettier from printConfig (cherry picked from commit 8ee6798)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
…m-csf-tools CSF-Tools: Remove prettier from printConfig (cherry picked from commit 8ee6798)
Merged
4 tasks
github-actions
bot
added
the
patch:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #23748
What I did
Remove prettier dep from csf-tools to fix perf regression
How to test
Ask MIchael for perf insights :)
Checklist
MIGRATION.MD
Maintainers
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>