Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: UI performance regression #23748

Closed
shilman opened this issue Aug 8, 2023 · 2 comments · Fixed by #23766
Closed

[Bug]: UI performance regression #23748

shilman opened this issue Aug 8, 2023 · 2 comments · Fixed by #23766

Comments

@shilman
Copy link
Member

shilman commented Aug 8, 2023

Describe the bug

We are seeing a performance regression in Storybook's startup time, possibly due to the new "experimental" components

Here is the time to first render for the React-Vite project over time:

image

Drilling in, it appears to have been introduced around this commit, potentially somehow due to the new icons? (Pink column is time to preview responsive)

image

Another clue is that the build size (purple column above) also increased around the same time:

image

To Reproduce

https://lookerstudio.google.com/u/0/reporting/6a438ac0-fe04-490c-ba91-f12a5bb6e917/page/p_54yskb3a7c

System

No response

Additional context

No response

@shilman
Copy link
Member Author

shilman commented Aug 8, 2023

Digging in more, I think the commit I highlighted above is indeed the culprit. This is me filtering by the branch charles-update-controls-addon that introduced the commit and you can clearly see the bump before and after on this narrowed down view (pink & dark purple columns):

image

@shilman
Copy link
Member Author

shilman commented Aug 9, 2023

Update: there are two different perf regressions going on here!

  1. startup time = d8d8cac
  2. preview size = 0005430

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants