-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blocks: Add of
prop to Title
#23728
Blocks: Add of
prop to Title
#23728
Conversation
c47b7eb
to
703e9bf
Compare
Partially implements storybookjs#22490
703e9bf
to
975c32d
Compare
of
prop
Hey @JReinhold could you please take a look? |
@JReinhold Is this an easy PR to review & merge? |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 51ede75. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR and your patience. I modified it slightly, LGTM. ❤️
of
propof
prop to Title block
of
prop to Title blockof
prop to Title
Partially implements #22490
What I did
of
prop for Title, only handling 'meta'of
prop toSubtitle
#22552 as an exampleHow to test
Questions for maintainers
MIGRATION.md
in this instance?Checklist
MIGRATION.MD
Maintainers
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]