Blocks: Add of prop to Subtitle
#22552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
5 tasks
kylegach
reviewed
Aug 7, 2023
docs/api/doc-block-subtitle.md
Outdated
| @@ -24,10 +24,16 @@ import { Subtitle } from '@storybook/blocks'; | |||
|
|
|||
| `Subtitle` is configured with the following props: | |||
|
|
|||
| ### `of` | |||
There was a problem hiding this comment.
Thanks for updating the API reference! ❤️
Could you please keep these props in alphabetical order?
joaonunomota
requested review from
JReinhold,
cdedreuille and
jonniebigodes
as code owners
2 tasks
joaonunomota
changed the title
of prop to Subtitle
|
@JReinhold Hi! Is there anything that I can update / fix for a pull request review? It would be nice if this PR and #23728 could go out with #23849. |
|
Sorry @joaonunomota I've missed this. I'll review this early next week |
ndelangen
changed the title
of prop to Subtitleof prop to Subtitle
|
@JReinhold please review? |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 1c204ea. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
JReinhold
approved these changes
Apr 22, 2024
44 tasks
shilman
changed the title
of prop to Subtitleof prop to Subtitle
8 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes part of #22490
What I did
ofprop viauseOfwith "meta" as only valid typeHow to test
yarn storybook:blocksChecklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]