Next.js: Support disableStaticImages setting #23167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinpalkovic
added
bug
patch:yes
valentinpalkovic
changed the title
valentinpalkovic
added
the
ci:daily
|
Very much interested in this. What is the expected timeline for this being available on npm? |
|
Hi! Thank you for working on this fix! My team is also very interested in this work as it's a blocker for our app's upgrade to storybook v7. Seconding the above question - what is the timeline for its release? |
valentinpalkovic
deleted the
valentin/support-disable-static-images-prop-in-nextjs
branch
7 tasks
JReinhold
pushed a commit
that referenced
this pull request
Jul 2, 2023
…tatic-images-prop-in-nextjs Next.js: Support disableStaticImages setting (cherry picked from commit eda9fc2)
Merged
15 tasks
github-actions
bot
added
the
patch:done
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22899
What I did
Support disableStaticImages setting in Next.js-based Storybooks.
How to test
import asset from './asset.jpg'shouldn't return an object anymore, but a plain string instead, which can be passed to an<img ... />element.Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]