Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: @storybook/nextjs does not respect disableStaticImages flag in next.config.js #22899

Closed
joebates-gfm opened this issue Jun 2, 2023 · 1 comment · Fixed by #23167
Closed

Comments

@joebates-gfm
Copy link

joebates-gfm commented Jun 2, 2023

Describe the bug

NextJs has an option to disableStaticImages in case a user wants to use an images string directly, instead of using the object. That is the way we have our front-end app setup. However with the latest update to storybook v7 using @storybook/nextjs that flag is not respected when we pass in the next.config.js file

    framework: {
        name: "@storybook/nextjs",
        options: {
            nextConfigPath: path.resolve(__dirname, "../next.config.js"),
        },
    },

To Reproduce

Here is an MVC repository to reproduce:
https://github.com/joebImagine/disablestaticimages_experiment

  • first run yarn
  • fire up the app yarn dev
  • fire up storybook yarn storybook
  • notice that the image shows in the app, but is broken in storybook

System

No response

Additional context

No response

@joebates-gfm
Copy link
Author

Do we know if there will be any traction on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants