Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Import CallContext and CallOptions as type #684

Merged
merged 2 commits into from
Oct 12, 2022

Conversation

dankeboy36
Copy link
Contributor

This PR proposes two changes:

  • When generating the nice-grpc output, the CallContext and CallOptions are not needed at runtime, so a type-only import is sufficient.
  • Format code step in the documentation.

Closes #677


Great lib, thank you!

When generating the nice-grpc output, CallContext and CallOptions
only needed for the typing.

Closes stephenh#677

Signed-off-by: dankeboy36 <[email protected]>
@dankeboy36 dankeboy36 changed the title Import CallContext and CallOptions as type Import CallContext and CallOptions as type Oct 12, 2022
@dankeboy36 dankeboy36 changed the title Import CallContext and CallOptions as type feat: Import CallContext and CallOptions as type Oct 12, 2022
@stephenh
Copy link
Owner

Looks great, thanks!

@stephenh stephenh merged commit 8b388f6 into stephenh:main Oct 12, 2022
stephenh pushed a commit that referenced this pull request Oct 12, 2022
# [1.127.0](v1.126.1...v1.127.0) (2022-10-12)

### Features

* **client:** allow overriding the service identifier ([#683](#683)) ([10c7c99](10c7c99))
* Import CallContext and CallOptions as type ([#684](#684)) ([8b388f6](8b388f6)), closes [#677](#677)
@stephenh
Copy link
Owner

🎉 This PR is included in version 1.127.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider importing only type of CallContext and CallOptions with outputServices=nice-grpc
2 participants