feat(client): allow overriding the service identifier #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenh
approved these changes
Oct 12, 2022
Currently the service identifier is the fully qualified "fullName" of the service, for example, "simple.Echoer" This identifier is hard-coded in the auto-generated client with string literals. Instead, allow overriding the service ID with a new optional argument in the client constructor, default the service ID to the fullName, and store the ID in a read-only field on the client object. This allows the user to override the service ID if desired while still maintaining the old behavior otherwise. Signed-off-by: Christian Stewart <[email protected]>
paralin
force-pushed
the
client-override-service-id
branch
from
0a8ab99 to
84c33ad
Compare
|
Updated syntax: |
|
Looks great! |
stephenh
pushed a commit
that referenced
this pull request
Oct 12, 2022
|
🎉 This PR is included in version 1.127.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the service identifier is the fully qualified "fullName" of the service, for example, "simple.Echoer"
This identifier is hard-coded in the auto-generated client with string literals.
Instead, allow overriding the service ID with a new optional argument in the client constructor, default the service ID to the fullName, and store the ID in a read-only field on the client object.
This allows the user to override the service ID if desired while still maintaining the old behavior otherwise.