Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deleteFramebuffer shouldn't throw if GL context is lost/destroyed #90

Open
gre opened this issue Dec 7, 2016 · 0 comments
Open

deleteFramebuffer shouldn't throw if GL context is lost/destroyed #90

gre opened this issue Dec 7, 2016 · 0 comments

Comments

@gre
Copy link
Member

gre commented Dec 7, 2016

If I destroy the GL context earlier, a fbo.dispose() throw an error, which is not the case in WebGL.

   Invalid GL context
        at Error (native)

      at WebGLFramebuffer.Object.<anonymous>.WebGLFramebuffer._performDelete (node_modules/gl/webgl.js:1743:22)
      at checkDelete (node_modules/gl/webgl.js:505:9)
      at WebGLRenderingContext.deleteFramebuffer (node_modules/gl/webgl.js:1762:3)
      at Framebuffer.Object.<anonymous>.proto.dispose (node_modules/gl-fbo/fbo.js:357:6)
gre added a commit to gre/gl-react that referenced this issue Dec 7, 2016
@gre
_destroyGLObjects() only call dispose if gl is available
e921b83 
this is a workaround for tests to pass ( stackgl/headless-gl#90 ), as soon as React have this fixed facebook/react#8512
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gre