Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test renderer unmount #8512

Merged
merged 3 commits into from
Dec 14, 2016
Merged

Fix test renderer unmount #8512

merged 3 commits into from
Dec 14, 2016

Conversation

gre
Copy link
Contributor

@gre gre commented Dec 7, 2016

Fixes #8459

@gre gre mentioned this pull request Dec 7, 2016
Closed
gre added a commit to gre/gl-react that referenced this pull request Dec 7, 2016
@gre
_destroyGLObjects() only call dispose if gl is available
3609022 
this is a workaround for tests to pass, as soon as React have this fixed facebook/react#8512
gre added a commit to gre/gl-react that referenced this pull request Dec 7, 2016
@gre
_destroyGLObjects() only call dispose if gl is available
e921b83 
this is a workaround for tests to pass ( stackgl/headless-gl#90 ), as soon as React have this fixed facebook/react#8512
@aweary aweary self-assigned this Dec 9, 2016
aweary
aweary approved these changes Dec 9, 2016
View reviewed changes
Copy link
Contributor

@aweary aweary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @gre! LGTM

@aweary
Copy link
Contributor

aweary commented Dec 9, 2016

@gre can you run the scripts/fiber/record-test script and add the results to this please? I think we can merge afterwards

@gre
Copy link
Contributor Author

gre commented Dec 9, 2016

done

@aweary aweary merged commit 931cad5 into facebook:master Dec 14, 2016
@aweary
Copy link
Contributor

aweary commented Dec 14, 2016

Thanks again @gre!

@gaearon
Copy link
Collaborator

gaearon commented Feb 6, 2017

@aweary

Please always set the "next" (non-specific) milestone when merging. Otherwise the release tool won't see the pull request and we'll keep skipping it until the next major.

@gaearon gaearon added this to the 15-hipri milestone Feb 6, 2017
bvaughn pushed a commit that referenced this pull request Mar 29, 2017
@gre
Fix test renderer unmount (#8512)
17434d7 
* [react-test-renderer] unmount the inner instances

Fixes #8459

* add a test for #8459

* add new test in tests-passing.txt
@bvaughn bvaughn mentioned this pull request Apr 6, 2017
Closed
@renovate renovate bot mentioned this pull request Feb 2, 2018
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aweary aweary aweary approved these changes

Assignees

@aweary aweary

Labels
CLA Signed
Projects
None yet
Milestone
15-hipri
Development

Successfully merging this pull request may close these issues.
4 participants
@gre @aweary @gaearon @facebook-github-bot