-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement for compare #1570
Draft
doki23
wants to merge
2
commits into
spiraldb:develop
Choose a base branch
from
doki23:for_compare
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
implement for compare #1570
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
use vortex_array::compute::{compare, CompareFn, Operator}; | ||
use vortex_array::ArrayData; | ||
use vortex_error::VortexResult; | ||
|
||
use crate::{decompress, FoRArray, FoREncoding}; | ||
|
||
impl CompareFn<FoRArray> for FoREncoding { | ||
fn compare( | ||
&self, | ||
lhs: &FoRArray, | ||
rhs: &ArrayData, | ||
operator: Operator, | ||
) -> VortexResult<Option<ArrayData>> { | ||
// this is cheap | ||
let owned_lhs = lhs.clone(); | ||
let decompressed_lhs = decompress(owned_lhs)?; | ||
compare(decompressed_lhs, rhs, operator).map(Some) | ||
} | ||
} | ||
|
||
#[cfg(test)] | ||
mod tests { | ||
use vortex_array::array::PrimitiveArray; | ||
use vortex_array::compute::{compare, Operator}; | ||
use vortex_array::validity::Validity; | ||
use vortex_array::IntoArrayVariant; | ||
|
||
use crate::for_compress; | ||
|
||
#[test] | ||
fn test_for_compare() { | ||
let lhs = PrimitiveArray::from_vec(vec![1i32, 2, 3, 4, 5], Validity::AllValid); | ||
let lhs = for_compress(&lhs).unwrap(); | ||
let rhs = PrimitiveArray::from_vec(vec![1i32, 2, 9, 4, 5], Validity::AllValid); | ||
assert_eq!( | ||
compare(lhs, rhs, Operator::Eq) | ||
.unwrap() | ||
.into_bool() | ||
.unwrap() | ||
.boolean_buffer(), | ||
vec![true, true, false, true, true].into() | ||
); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So by default, the compare function will fall back to canonicalizing an array into the Arrow representation and then running the compare kernel over it.
So we should only implement a compute function for an encoding when it is able to short-cut some work.
In the case of FoR, if the RHS is constant
rhs.as_constant()
, then you could subtract thelhs.reference()
value and then push-down the comparison without decompressing.For FoR, this doesn't itself make the compare any cheaper, but it does allow FoR's child to possible implement a cheaper comparison.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Get it, thanks