implement for compare #1570
Draft
implement for compare #1570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatesn
reviewed
Dec 5, 2024
| ) -> VortexResult<Option<ArrayData>> { | ||
| // this is cheap | ||
| let owned_lhs = lhs.clone(); | ||
| let decompressed_lhs = decompress(owned_lhs)?; |
There was a problem hiding this comment.
So by default, the compare function will fall back to canonicalizing an array into the Arrow representation and then running the compare kernel over it.
So we should only implement a compute function for an encoding when it is able to short-cut some work.
In the case of FoR, if the RHS is constant rhs.as_constant(), then you could subtract the lhs.reference() value and then push-down the comparison without decompressing.
For FoR, this doesn't itself make the compare any cheaper, but it does allow FoR's child to possible implement a cheaper comparison.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1420