Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support latest PySide6 #2688

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Support latest PySide6 #2688

merged 2 commits into from
Apr 5, 2024

Conversation

ptsavol
Copy link
Member

@ptsavol ptsavol commented Apr 4, 2024

Allow using the latest PySide6 (6.6.3.1). Disallow broken 6.5.2 and 6.6.3 versions.

  • Updated some tests, which caused fatal Windows errors on PySide6 6.6.3.1.

Fixes #2345

Checklist before merging

  • Unit tests have been added/updated accordingly
  • Code has been formatted by black
  • Unit tests pass

@ptsavol ptsavol self-assigned this Apr 4, 2024
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.35%. Comparing base (8114ed6) to head (d1428eb).

Additional details and impacted files
@@           Coverage Diff            @@
##           0.8-dev    #2688   +/-   ##
========================================
  Coverage    65.35%   65.35%           
========================================
  Files          194      194           
  Lines        35545    35545           
  Branches      6038     6038           
========================================
+ Hits         23231    23232    +1     
- Misses       11080    11081    +1     
+ Partials      1234     1232    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ptsavol ptsavol merged commit f997703 into 0.8-dev Apr 5, 2024
18 checks passed
@ptsavol ptsavol deleted the support_pyside66 branch April 5, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant