-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for PySide6 6.6 #2345
Comments
Re spine-tools/Spine-Toolbox#2345 (cherry picked from commit b6fe4b8)
The latest PySide6 (6.6.3.1) seems to be working fine. I'll test it a little bit more and then merge the two PR's above to 0.8-dev branch. By the way, Python 3.12 support was added to PySide6 in v6.6.1, so this should help issue #2522 as well. |
Nice! The biggest blocker with Python 3.12 is still the old version of Dagster we are stuck with. |
Done. @soininen what do you think about supporting pyside6 6.6 in |
Go ahead if it is not too much work. It definitely makes life easier for us developers who switch branches regularly. |
PySide6 6.5.3 was just released and we seem to have a bunch of problems related to disconnect() signals. We need to investigate if the 6.5.3 version is broken or if we need to adjust our codebase to work with the new version. My hunch is that 6.5.3 is enforcing a policy that you cannot disconnect a signal that is not connected without getting a RuntimeError. In the meantime, we should disallow 6.5.3 from pyproject.toml on both toolbox and spine-items.
As an example, here's one traceback from action https://github.com/spine-tools/Spine-Toolbox/actions/runs/6454620214
The text was updated successfully, but these errors were encountered: