Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PySide6 6.6 #2345

Closed
ptsavol opened this issue Oct 9, 2023 · 4 comments
Closed

Add support for PySide6 6.6 #2345

ptsavol opened this issue Oct 9, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@ptsavol
Copy link
Member

ptsavol commented Oct 9, 2023

PySide6 6.5.3 was just released and we seem to have a bunch of problems related to disconnect() signals. We need to investigate if the 6.5.3 version is broken or if we need to adjust our codebase to work with the new version. My hunch is that 6.5.3 is enforcing a policy that you cannot disconnect a signal that is not connected without getting a RuntimeError. In the meantime, we should disallow 6.5.3 from pyproject.toml on both toolbox and spine-items.

As an example, here's one traceback from action https://github.com/spine-tools/Spine-Toolbox/actions/runs/6454620214

test_add_to_existing_plot (tests.test_plotting.TestPlotPivotTableSelection) ... Traceback (most recent call last):
  File "/home/runner/work/Spine-Toolbox/Spine-Toolbox/spinetoolbox/spine_db_editor/widgets/tabular_view_mixin.py", line 759, in _change_selected_frozen_row
    with disconnect(selection_model.currentChanged, self._change_selected_frozen_row):
  File "/opt/hostedtoolcache/Python/3.9.18/x64/lib/python3.9/contextlib.py", line 119, in __enter__
    return next(self.gen)
  File "/home/runner/work/Spine-Toolbox/Spine-Toolbox/spinetoolbox/helpers.py", line 1261, in disconnect
    signal.disconnect(slot)
RuntimeError: Failed to disconnect signal currentChanged(QModelIndex,QModelIndex).
@ptsavol ptsavol added the bug Something isn't working label Oct 9, 2023
@ptsavol ptsavol self-assigned this Oct 9, 2023
ptsavol added a commit to spine-tools/spine-items that referenced this issue Oct 9, 2023
ptsavol added a commit that referenced this issue Oct 9, 2023
ptsavol added a commit that referenced this issue Oct 9, 2023
Re #2345

(cherry picked from commit 2cebe77)
ptsavol added a commit to spine-tools/spine-items that referenced this issue Oct 9, 2023
ptsavol added a commit that referenced this issue Apr 4, 2024
ptsavol added a commit to spine-tools/spine-items that referenced this issue Apr 4, 2024
@ptsavol ptsavol changed the title Investigate problems with PySide 6.5.3 Add support for PySide6 6.6 Apr 4, 2024
@ptsavol
Copy link
Member Author

ptsavol commented Apr 4, 2024

The latest PySide6 (6.6.3.1) seems to be working fine. I'll test it a little bit more and then merge the two PR's above to 0.8-dev branch. By the way, Python 3.12 support was added to PySide6 in v6.6.1, so this should help issue #2522 as well.

@soininen
Copy link
Contributor

soininen commented Apr 5, 2024

By the way, Python 3.12 support was added to PySide6 in v6.6.1, so this should help issue #2522 as well.

Nice! The biggest blocker with Python 3.12 is still the old version of Dagster we are stuck with.

ptsavol added a commit to spine-tools/spine-items that referenced this issue Apr 5, 2024
ptsavol added a commit that referenced this issue Apr 5, 2024
@ptsavol
Copy link
Member Author

ptsavol commented Apr 5, 2024

Done. @soininen what do you think about supporting pyside6 6.6 in master as well? It would make life easier for users who jump between branches. Maybe better to let the dust settle in 0.8-dev first and then do it, if you think it's a good idea.

@ptsavol ptsavol closed this as completed Apr 5, 2024
@soininen
Copy link
Contributor

soininen commented Apr 5, 2024

what do you think about supporting pyside6 6.6 in master as well?

Go ahead if it is not too much work. It definitely makes life easier for us developers who switch branches regularly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants