Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DB editor showing wrong values after committing #2259

Closed
PiispaH opened this issue Aug 17, 2023 · 0 comments · Fixed by spine-tools/Spine-Database-API#259
Closed

DB editor showing wrong values after committing #2259

PiispaH opened this issue Aug 17, 2023 · 0 comments · Fixed by spine-tools/Spine-Database-API#259
Assignees
@soininen
Labels
bug Something isn't working
Milestone
V0.7

Comments

@PiispaH
Copy link
Collaborator

PiispaH commented Aug 17, 2023

Sometimes after committing changes to a db you need to press the reload button to see the actual committed data.
image

To reproduce at least one object with a parameter value is needed and another object that may or may not have parameter values.

  1. Delete an object
  2. Change the value of an existing object
  3. Commit the changes
  4. The value that was changed will be set back to the initial value until the db is reloaded
@PiispaH PiispaH added the bug Something isn't working label Aug 17, 2023
@PiispaH PiispaH added this to the V0.7 milestone Aug 17, 2023
@soininen soininen self-assigned this Aug 17, 2023
soininen added a commit to spine-tools/Spine-Database-API that referenced this issue Aug 17, 2023
@soininen
Don't overwrite cache when removing items
071da6a 
We call cascade_remove_items() from Toolbox without supplying db cache
apparently to ensure that all cascading ids get cached in cascading_ids().
The call to make_cache(), however, overwrote all existing items in
the cache destroying pending updates. We now supply a new parameter,
keep_existing, to make_cache() to prevent overwriting existing items.

Re spine-tools/Spine-Toolbox#2259
@soininen soininen mentioned this issue Aug 17, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@soininen soininen

Labels
bug Something isn't working
Projects
None yet
Milestone
V0.7
Development

Successfully merging a pull request may close this issue.

Fix item removal ovewriting updates in database cache spine-tools/Spine-Database-API
2 participants
@soininen @PiispaH