Fix item removal ovewriting updates in database cache #259
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We call
cascade_remove_items()
from Toolbox without supplying db cache apparently to ensure that all cascading ids get cached incascading_ids()
. The call tomake_cache()
, however, overwrote all existing items in the cache destroying pending updates. We now supply a new parameter,keep_existing
, tomake_cache()
to prevent overwriting existing items.Fixes spine-tools/Spine-Toolbox#2259
Checklist before merging